[DO NOT MERGE] feat(vertexai): Add support for setting the API version - wait for the release date #17000
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
cynthiajoan reviewed Jan 22, 2025
packages/firebase_vertexai/firebase_vertexai/lib/src/model.dart Outdated Show resolved Hide resolved
cynthiajoan reviewed Jan 22, 2025
packages/firebase_vertexai/firebase_vertexai/lib/src/model.dart Outdated Show resolved Hide resolved
cynthiajoan reviewed Jan 22, 2025
packages/firebase_vertexai/firebase_vertexai/lib/src/model.dart Outdated Show resolved Hide resolved
cynthiajoan reviewed Jan 22, 2025
packages/firebase_vertexai/firebase_vertexai/lib/src/firebase_vertexai.dart Show resolved Hide resolved
andrewheard commented Jan 22, 2025
Contributor Author
andrewheard left a comment
andrewheard left a comment There was a problem hiding this comment.
Thanks for taking a look, @cynthiajoan!
packages/firebase_vertexai/firebase_vertexai/lib/src/model.dart Outdated Show resolved Hide resolved
packages/firebase_vertexai/firebase_vertexai/lib/src/firebase_vertexai.dart Show resolved Hide resolved
cynthiajoan approved these changes Jan 23, 2025
cynthiajoan changed the title 
Lyokone approved these changes Feb 5, 2025
| final String versionIdentifier; | ||
| | ||
| @override | ||
| String toString() => name; |
Contributor
There was a problem hiding this comment.
Should this be versionIdentifier for better clarity?
10 tasks
russellwheatley approved these changes Feb 5, 2025
Member
There was a problem hiding this comment.
I think this will conflict with Imagen PR: #16976 (review)
Might be easier to base off that branch, other than that, LGTM.
Contributor Author
| Closing this PR for now since it no longer needs to go out at the same time as (or before) Imagen. We're also considering not exposing it in the public API anymore. Will bring it back and rebase when the time comes. |
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description
WIP - See go/firebase-vertex-set-api-version (Google-internal only) for more details.
Added the ability to specify an API version (e.g., v1 or v1beta) when initializing a
GenerativeModelusing a newRequestOptionsclass to match the other SDKs. This is the Flutter/Dart equivalent of firebase/firebase-ios-sdk#14356.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?
TODOs