Skip to content

[Vertex AI] Add internal apiVersion parameter to RequestOptions #14356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 30, 2025
Merged

[Vertex AI] Add internal apiVersion parameter to RequestOptions #14356

merged 3 commits into from
Jan 30, 2025

Conversation

@andrewheard
Copy link
Contributor

@andrewheard andrewheard commented Jan 16, 2025 •
edited
Loading

Added an internal constructor for RequestOptions that supports specifying an API version (e.g., v1 or v1beta).

See go/firebase-vertex-set-api-version (Google-internal only) for more details.

#14405
#no-changelog
@andrewheard
Copy link
Contributor Author

andrewheard commented Jan 17, 2025

Removed ExpressibleByStringLiteral conformance for APIVersion since we don't currently have a use-case where using the static properties APIVersion.v1 and APIVersion.v1beta would not be sufficient.

Adding ExpressibleByStringLiteral conformance later, or a static func custom(_ versionIdentifier: String), wouldn't be breaking changes so they've been left out for now.
This was referenced Jan 20, 2025
Draft
Draft
Closed
@andrewheard andrewheard changed the title [Vertex AI] Add apiVersion parameter to RequestOptions [Vertex AI] Add internal apiVersion parameter to RequestOptions Jan 30, 2025
@andrewheard andrewheard marked this pull request as ready for review January 30, 2025 22:40
@andrewheard andrewheard requested a review from paulb777 January 30, 2025 22:40
@andrewheard andrewheard merged commit f946592 into main Jan 30, 2025
38 checks passed
@andrewheard andrewheard deleted the ah/vertex-api-version branch January 30, 2025 22:57
@github-actions github-actions bot mentioned this pull request Feb 26, 2025
Merged
@firebase firebase locked and limited conversation to collaborators Mar 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: firebaseai

2 participants

@andrewheard @paulb777