Skip to content

[Firebase AI] Increase the test timeout #1289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 11, 2025
Merged

[Firebase AI] Increase the test timeout #1289

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions firebaseai/testapp/Assets/Firebase/Sample/FirebaseAI/UIHandlerAutomated.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,9 @@ protected override void Start() {
logFunc: DebugLog
);

// Some of the AI tests tend to take a bit longer, so increase the timeout.
testRunner.TestTimeoutSeconds = 120f;
Comment on lines +123 to +124
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Jul 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Consider defining the test timeout as a constant to improve maintainability and readability. This also avoids magic numbers in the code.1

 const float kTestTimeoutSeconds = 120f; // Some of the AI tests tend to take a bit longer, so increase the timeout. testRunner.TestTimeoutSeconds = kTestTimeoutSeconds;

Style Guide References

Footnotes

  1. Magic numbers should be replaced with named constants. (link) ↩

base.Start();
}

Expand Down