Skip to content

Conversation

a-maurice
Copy link
Collaborator

Description

Provide details of the change, and generalize the change in the PR title above.

Some of the nightly tests are timing out because the youtube summary test is slow, so bump up the timeout.


Testing

Describe how you've tested these changes.

Running locally


Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @a-maurice, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

I've prepared this pull request to address test instability caused by timeouts in our automated test suite. The primary goal is to ensure that long-running tests, specifically the YouTube summary test, complete successfully without timing out, thereby improving the reliability of our nightly test runs.

Highlights

  • Test Timeout Adjustment: I've increased the default test timeout for automated AI tests to accommodate longer execution times, preventing premature test failures.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request increases the test timeout for Firebase AI tests. A suggestion was made to define the timeout value as a constant for better maintainability.

Comment on lines +123 to +124
// Some of the AI tests tend to take a bit longer, so increase the timeout.
testRunner.TestTimeoutSeconds = 120f;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Consider defining the test timeout as a constant to improve maintainability and readability. This also avoids magic numbers in the code.1

 const float kTestTimeoutSeconds = 120f; // Some of the AI tests tend to take a bit longer, so increase the timeout. testRunner.TestTimeoutSeconds = kTestTimeoutSeconds;

Style Guide References

Footnotes

  1. Magic numbers should be replaced with named constants. (link)

@a-maurice a-maurice merged commit 1a59fb8 into main Jul 11, 2025
5 checks passed
@a-maurice a-maurice deleted the am-test_timeout branch July 11, 2025 00:41
@firebase firebase locked and limited conversation to collaborators Aug 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
1 participant