Skip to content

Conversation

@merlinnot
Copy link
Contributor

Description

⚠️ This PR contains changes from #494, which should be merged first. I branched out of it because it's already approved and would cause conflicts. Once #494 is merged, this will contain a minimal set of changes.

Code sample

Not relevant.

@merlinnot
Copy link
Contributor Author

@thechenky Unfortunately I don't have permissions to assign you as a reviewer, as requested.

@thechenky thechenky self-requested a review July 3, 2019 21:15
@thechenky
Copy link
Contributor

Just merged 494, feel free to pull in master and update. Also, thanks for letting me know that you cannot request my review, I didn't know that before. Just pinging me on the PR is fine in this case :)

@merlinnot
Copy link
Contributor Author

It's already updated :)

@merlinnot merlinnot mentioned this pull request Jul 3, 2019
Copy link
Contributor

@thechenky thechenky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants