Extract configuration to break dependency cycle #494
Conversation
| @thechenky Unfortunately I don't have permissions to assign you as a reviewer, as requested in the previous PR. |
| This still has formatting and lint changes ya? Let's remove those - I approved the lint/format PR and can merge that in now. |
| I thought you'll just merge the other PR straight away, so I can rebase this one. I have my editor set up to autofix and autoformat on save, hence these changes were applied to all of the files I touched. I reverted it manually. What's the process of merging PRs? Do we need more reviews first? |
| I merged the other two PRs, can you update with master? It should remove the extra formatting changes too. |
| Ah sorry missed your last comment - we should be good to go, I forgot I'm supposed to do the merging since you can't push that button :) |
| Only you have the power to do that ;) I've merged master, Travis takes a long time to run today, after yesterdays incident they still have a large backlog of jobs. |
| Just merged #492 also |
| Nice, this now looks like only relevant changes. Reviewing now :) |
| @thechenky When I was working on the comments, I made a small change to stricten type definitions for regions, hope that's fine -> 22b6d0b. |
| @merlinnot hm, I just ran the integration tests on master after merging this in, and they are failing on the deploy step with TS errors:
|
| It works if I remove the |
| I'll check that. |
| Unless there's something we can do to make this work with keeping |
| Actually, master integration tests being broken will block releases for GCF, so I'm going to submit the fix now and if we figure out a way to make it work with original version, we can add that in later. |
2 participants
Description
This PR moves definitions related to configuration options to
functions-configuration, as it causes an import cycle.This PR contains some changes made automatically by Prettier and TSLint, it will be gone once #493 is merged.
Code sample
Not relevant.