Skip to content

docs: align intro and readme translations #330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 4, 2021
Merged

docs: align intro and readme translations #330

merged 3 commits into from
Nov 4, 2021

Conversation

@sarmong
Copy link
Member

@sarmong sarmong commented Nov 1, 2021 •
edited by azinit
Loading

CHANGELOG

  • Поправил перевод в Intro Readme
  • Сделал перевод доки одинаковым с readme

Чеклист

  • Если при работе с документацией потребовалось использовать github-дискуссии, то стоит их прикрепить как see-also источники
  • Если PR связан с задачей, то необходимо проверить, что все требования по задаче выполнены
  • Перед тем, как отправлять изменения на ревью, нужно ознакомиться с CONTIBUTING-гайдлайнами
  • Перед тем, как отправлять изменения на ревью, нужно провести self-review своих изменений
  • Перед тем, как отправлять изменения на ревью, нужно дождаться CI-проверок
  • Перед тем, как отправлять изменения на ревью, нужно дать краткое описание изменений
@azinit azinit linked an issue Nov 2, 2021 that may be closed by this pull request
Помогите нам перевести feature-sliced / Help us translate feature-sliced #244
Closed
azinit
azinit suggested changes Nov 2, 2021
View reviewed changes
Copy link
Member

@azinit azinit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Кое что поправил бы, а в целом - пушка бомба 🚀
website/i18n/en/docusaurus-plugin-content-docs/current/intro.md Outdated
- Provides [**clarity, controllability and adaptability**][refs-arch-req] architecture
- Based on [**time-tested**][refs-motivation-why] design practices and concepts
- Provides [**explicitness, controllability and adaptability**][refs-arch-req] of architecture
- Based on [**experienced-checked**][refs-motivation-why] design practices and concepts
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Очепятка)

Но мб тогда и здесь и в ридми заменить на experience-tested?

По аналогии с battle-tested, так более правильно кмк

Suggested change
- Based on [**experienced-checked**][refs-motivation-why] design practices and concepts
- Based on [**experience-tested**][refs-motivation-why] design practices and concepts
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Вообще, мне больше нравится time-tested. Experience-tested/checked звучит как калька с русского. Что скажешь?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Щас призову кого надо))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Но чисто имхо - да, можно и "time-tested", но @KaraJovian получше подскажет
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@feature-sliced/core ping
website/i18n/en/docusaurus-plugin-content-docs/current/intro.md Outdated
# 🔎 Intro

A methodology for designing *frontend projects*, aimed [**at dividing the application according to business logic and scopes of responsibility.**][refs-splitting]
An architectural design methodology for *frontend projects*. It aims to [**divide an application according to business logic and scopes of responsibility.**][refs-splitting]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Думаю, можно взять прям полностью из ридмихи тогда да, прям начиная с "FeatureSliced is..."
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@azinit А FetureSliced может лучше писать через дефис? Feature-sliced
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

У нас пока приняты такие вариации))

  • FeatureSliced
  • Feature Sliced
  • feature-sliced

Даж если потом будет неоправдано, думаю никто не умрет от этого)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michalenr
@azinit
Copy link
Member

azinit commented Nov 4, 2021

@michalenr Рекомендую поскорей добить PR, т.к. там крупная реструктуризация на подходе)

#339
@azinit
Copy link
Member

azinit commented Nov 4, 2021

Можем остановиться на нашем промежуточном варианте пока с "time-tested"
@azinit
Copy link
Member

azinit commented Nov 4, 2021

@feature-sliced/core гляньте пож
@sarmong
Copy link
Member Author

sarmong commented Nov 4, 2021

Закинул фиксы по комментам
azinit
azinit previously approved these changes Nov 4, 2021
View reviewed changes
Copy link
Member

@azinit azinit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Пушка бомба, заходи еще 😎
@azinit azinit merged commit 714d53d into feature-sliced:master Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@sarmong @azinit