-
-
Couldn't load subscription status.
- Fork 782
⬆ Bump mypy from 1.4.1 to 1.18.2 #1560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Bumps [mypy](https://github.com/python/mypy) from 1.4.1 to 1.18.1. - [Changelog](https://github.com/python/mypy/blob/master/CHANGELOG.md) - [Commits](python/mypy@v1.4.1...v1.18.1) --- updated-dependencies: - dependency-name: mypy dependency-version: 1.18.1 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
f54feaf to 744954b Compare | | ||
| def get_annotations(class_dict: Dict[str, Any]) -> Dict[str, Any]: | ||
| return class_dict.get("__annotations__", {}) | ||
| return class_dict.get("__annotations__", {}) # type: ignore[no-any-return] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As on L425, where we're already ignoring it, the error is
Returning Any from function declared to return "dict[str, Any]" [no-any-return]
| Huh. On Python 3.9 the CI is failing with
But I don't see a single |
| The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The false positive notifications of the X | Y syntax go away when specifying from __future__ import annotations at the top of the file, as suggested here.
But even if this PR goes green, we shouldn't merge it. The mypy runs are still taking a ridiculous amount of time, something like 12-13 minutes. Each full CI run usually takes less than 1 minute when looking at current open PRs.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
| With Update: ignoring |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
| 📝 Docs preview for commit f30beb2 at: https://d085961e.sqlmodel.pages.dev |
📝 Docs previewLast commit d787c3f at: https://76cacab2.sqlmodel.pages.dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, feel free to merge when ready @svlandeg 🚀
| 🎉 |
|
|
Bumps mypy from 1.4.1 to 1.18.1.
Changelog
Sourced from mypy's changelog.
... (truncated)
Commits
03fbaa9bump version to 1.18.1 due to wheels failureb44a1fbremoved +dev from version7197a99Removed Unreleased in the Changelog for Release 1.18 (#19827)ee61cecUpdates to 1.18 changelog (#19826)24eed0bInitial changelog for release 1.18 (#19818)0ca1f2aExpose --fixed-format-cache if compiled (#19815)2ce1bb2[mypyc] Fix subclass processing in detect_undefined_bitmap (#19787)a6b55f0feat: new mypyc primitives for weakref.proxy (#19217)5a323ddMake --allow-redefinition-new argument public (#19796)8638eb4[stubtest] temporary--ignore-disjoint-basesflag (#19740)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)