Skip to content

👌 Improve performance of "text" inline rule #347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 17, 2024
Merged

👌 Improve performance of "text" inline rule #347

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9616588
👌 Improve performance of "text" inline rule
hukkin Dec 17, 2024
50c9f07
compile regex lazily
hukkin Dec 17, 2024
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions markdown_it/rules_inline/text.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
import functools
import re

# Skip text characters for text token, place those to pending buffer
# and increment current pos
from .state_inline import StateInline
Expand Down Expand Up @@ -36,11 +39,17 @@
}


@functools.cache
def _terminator_char_regex() -> re.Pattern[str]:
return re.compile("[" + re.escape("".join(_TerminatorChars)) + "]")


def text(state: StateInline, silent: bool) -> bool:
pos = state.pos
posMax = state.posMax
while (pos < posMax) and state.src[pos] not in _TerminatorChars:
pos += 1

terminator_char = _terminator_char_regex().search(state.src, pos)
pos = terminator_char.start() if terminator_char else posMax

if pos == state.pos:
return False
Expand Down
Loading