Skip to content

Conversation

hukkin
Copy link
Contributor

@hukkin hukkin commented Dec 17, 2024

This slightly deviates from JavaScript, but improves performance a lot.

Below the before/after results from tox -e py312-bench-core.

Before:

------------------------------------------ benchmark 'core': 1 tests ------------------------------------------ Name (time in ms) Min Max Mean StdDev Median IQR Outliers OPS Rounds Iterations --------------------------------------------------------------------------------------------------------------- test_spec 80.6105 90.4756 83.9440 4.1692 81.2779 7.7111 4;0 11.9127 12 1 --------------------------------------------------------------------------------------------------------------- 

After:

------------------------------------------ benchmark 'core': 1 tests ------------------------------------------ Name (time in ms) Min Max Mean StdDev Median IQR Outliers OPS Rounds Iterations --------------------------------------------------------------------------------------------------------------- test_spec 74.6913 84.1540 78.3273 3.9836 75.6576 8.0403 4;0 12.7669 13 1 --------------------------------------------------------------------------------------------------------------- 
Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.25%. Comparing base (1a43fa3) to head (50c9f07).
Report is 3 commits behind head on master.

Additional details and impacted files
@@ Coverage Diff @@ ## master #347 +/- ## ======================================= Coverage 95.24% 95.25% ======================================= Files 64 64 Lines 3431 3436 +5 ======================================= + Hits 3268 3273 +5  Misses 163 163 
Flag Coverage Δ
pytests 95.25% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
@chrisjsewell
Copy link
Member

yeh looks good cheers

@chrisjsewell chrisjsewell merged commit c5161b5 into executablebooks:master Dec 17, 2024
16 checks passed
@hukkin hukkin deleted the fast-text-inline branch December 17, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants