Skip to content

Update toolchain to support std::remainder #7849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 29, 2021
Merged

Update toolchain to support std::remainder #7849

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
427e593
Update toolchain to support std::remainder
earlephilhower Jan 28, 2021
400d43f
Merge branch 'master' into fixrem
earlephilhower Jan 28, 2021
75e64d5
Add device test for std::remainder variants
earlephilhower Jan 29, 2021
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Add device test for std::remainder variants
  • Loading branch information
@earlephilhower
earlephilhower committed Jan 29, 2021
commit 75e64d53fc466f8d881af517795cfed787e017d0
8 changes: 8 additions & 0 deletions tests/device/test_sw_newlib/test_sw_newlib.ino
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
#include <BSTest.h>
#include <cmath>
BS_ENV_DECLARE();


Expand Down Expand Up @@ -30,6 +31,13 @@ TEST_CASE("#612 fmod and sqrt work", "[newlib]")
CHECK(fabs(fmod(-10, -3) - (-1.0)) < 1e-5);
}


TEST_CASE("#7845 std::remainder works", "[newlib]")
{
CHECK(fabs(std::remainder((double)10.123456, (double)5.0) - (double)0.123456) < 1e-5);
CHECK(fabs(std::remainder((float)15.123456, (float)5.0) - (float)0.123456) < 1e-5);
}

void loop()
{
}