Skip to content

Conversation

earlephilhower
Copy link
Collaborator

Update newlib to enable the __ieee754_remainder(f) calls required by
std::remainder and others.

Fixes #7845

Update newlib to enable the __iee745_remainder(f) calls required by std::remainder and others. Fixes esp8266#7845
@mcspr
Copy link
Collaborator

mcspr commented Jan 29, 2021

#7845 successfully builds using Windows toolchain, no surprises so far

Does this need a test similar to this?

TEST_CASE("#612 fmod and sqrt work", "[newlib]")
{
CHECK(fabs(fmod(2.0, 1.5) - 0.5) < 1e-6);
CHECK(fabs(fmod(-10, -3) - (-1.0)) < 1e-5);
}

to at least call it once

@earlephilhower
Copy link
Collaborator Author

Good idea, @mcspr . Since it's in newlib and not the core the chance of it re-breaking is low but I'll throw something in so that it at least checks linkage (the base problem here) once somewhere...

@earlephilhower earlephilhower merged commit 20413f8 into esp8266:master Jan 29, 2021
@earlephilhower earlephilhower deleted the fixrem branch January 29, 2021 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants