Enable C2 HIL #1680
Merged
Enable C2 HIL #1680
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Member Author
SergioGasquez force-pushed the feat/hil-c2 branch from 622f13c to 2a9d165 Compare 
Member
| What's the order of operations here? I guess we need to physically move the wires before we can merge this? |
Member Author
Yes, we would need to update the wiring and merge this asap after the wires are updated (otherwise HIL workflows will fail) |
JurajSadel approved these changes Jun 17, 2024
Contributor
JurajSadel left a comment
JurajSadel left a comment There was a problem hiding this comment.
LGTM, thanks! I can do the wiring changes.
Member
| @JurajSadel please go ahead and change the wires, then merge this once that's complete. Thank you 🥰 |
Member
| @JurajSadel any updates here? |
SergioGasquez force-pushed the feat/hil-c2 branch from 2a9d165 to 0fbe911 Compare 
SergioGasquez force-pushed the feat/hil-c2 branch from 0fbe911 to a270eb8 Compare Member Author
| Tomas just updated the wiring! Ill proceed with the merging |
github-merge-queue bot pushed a commit that referenced this pull request Jun 26, 2024
* ci: Enable c2 hil * docs: Update pins and add C2 * feat: Update C2 probe-rs args * test: Update pins and disable failing tests * docs: Update S3 wires
github-merge-queue bot removed this pull request from the merge queue due to failed status checks github-merge-queue bot pushed a commit that referenced this pull request Jun 26, 2024
* ci: Enable c2 hil * docs: Update pins and add C2 * feat: Update C2 probe-rs args * test: Update pins and disable failing tests * docs: Update S3 wires * ci: Enable C2 hil tests
github-merge-queue bot removed this pull request from the merge queue due to failed status checks SergioGasquez force-pushed the feat/hil-c2 branch from cc57ffc to 3ea076a Compare Member Author
| Currently, C2 HIL is not added as a required check as probe-rs cant detect the chip in our self-hosted runner. Ill try to fix this asap |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution!
We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:
Submission Checklist 📝
cargo xtask fmt-packagescommand to ensure that all changed code is formatted correctly.CHANGELOG.mdin the proper section.Extra:
Pull Request Details 📖
Description
GPIO2andGPIO4, we should now useGPIO2and `GPIO3delays are failing, added the error to HIL testing issues on different targets #1524 and disabled them for C2Important
Once merged we need to add the
HIL Test | esp32c2test to the required checksTesting
Locally run the test suite, modifying the connected pins, without errors for C2, C3, C6, H2, S2 and S3.