AWS ELB add support for ALPN policy details in NLB logs #11590
Conversation
🚀 Benchmarks reportTo see the full report comment with |
andrewkroh added the Team:Obs-InfraObs 
shmsr left a comment
shmsr left a comment There was a problem hiding this comment.
Left one comment. Rest looks good!
kcreddy left a comment
kcreddy left a comment There was a problem hiding this comment.
Adding code owner approval.
| @elastic/obs-ds-hosted-services , could you please review the PR? |
zmoog left a comment
zmoog left a comment There was a problem hiding this comment.
LGTM, I left a question about alpn_client_preference_list.
| description: > | ||
| The value of the application_layer_protocol_negotiation extension in the client hello message. This value is URL-encoded. |
There was a problem hiding this comment.
Why did we keep the alpn_client_preference_list in its source form and not parse it as a list? Do we expect users to need it in its pristine form?
There was a problem hiding this comment.
In this is needed, we can do something like this. Keeping it for further reference / enhancement
- script: lang: painless source: >- if (ctx?.aws?.elb?.alpn_client_preference_list != null && ctx?.aws?.elb?.alpn_client_preference_list != '-' && !ctx?.aws?.elb?.alpn_client_preference_list.trim().isEmpty()) { String cleanedList = ctx.aws.elb.alpn_client_preference_list; // Use regex to split by comma String[] protocols = /,/.split(cleanedList); ArrayList filteredProtocols = new ArrayList(); for (String protocol : protocols) { def protocol_temp = /[\\"]/.matcher(protocol).replaceAll(""); if (!protocol_temp.trim().isEmpty()) { filteredProtocols.add(protocol_temp.trim()); } } ctx.aws.elb.alpn_client_preference_list = filteredProtocols; } else { // Set to an empty array if the conditions are not met ctx.aws.elb.alpn_client_preference_list = []; } | /test |
packages/aws/data_stream/elb_logs/elasticsearch/ingest_pipeline/default.yml Outdated Show resolved Hide resolved
…e/default.yml Co-authored-by: kaiyan-sheng <kaiyan.sheng@elastic.co>
💚 Build Succeeded
History
cc @agithomas |
|
| Package aws - 2.31.2 containing this change is available at https://epr.elastic.co/search?package=aws |
* AWS ELB add support for ALPN policy details in NLB logs
* AWS ELB add support for ALPN policy details in NLB logs
9 participants
Proposed commit message
Add support for extracting ALPN policy related details from NLB access log data.
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
elastic-package build && elastic-package stack up -v -d --services package-registryRelated issues
Screenshots