Skip to content

Add AWS ELB add support for ALPN policy details in NLB logs #11706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 12, 2024
Merged

Add AWS ELB add support for ALPN policy details in NLB logs #11706

merged 2 commits into from
Nov 12, 2024

Conversation

@agithomas
Copy link
Contributor

@agithomas agithomas commented Nov 12, 2024 •
edited
Loading

  • Bug

Proposed commit message

Add support for extracting ALPN policy related details from NLB access log data.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • Update the new pattern in the pipeline test files and generate new expected log data
  • Package upgrade testing

How to test this PR locally

elastic-package build && elastic-package stack up -v -d --services package-registry

Related issues

Screenshots

image
@elastic-vault-github-plugin-prod
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport
@elastic-sonarqube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube
@elasticmachine
Copy link

💚 Build Succeeded
@agithomas agithomas marked this pull request as ready for review November 12, 2024 07:22
@agithomas agithomas requested review from a team as code owners November 12, 2024 07:22
@andrewkroh andrewkroh added bugfix Pull request that fixes a bug issue Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] labels Nov 12, 2024
zmoog
zmoog approved these changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@zmoog zmoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
ishleenk17
ishleenk17 approved these changes Nov 12, 2024
View reviewed changes
Copy link
Member

@ishleenk17 ishleenk17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the PR, considering its a backport and actual changes have already been reviewed and approved!
@agithomas agithomas merged commit 080e519 into elastic:backport-aws-2.30 Nov 12, 2024
5 checks passed
@agithomas agithomas mentioned this pull request Nov 12, 2024
Merged
@elastic-vault-github-plugin-prod
Copy link

Package aws - 2.30.2 containing this change is available at https://epr.elastic.co/package/aws/2.30.2/
@agithomas agithomas self-assigned this Nov 22, 2024
qcorporation pushed a commit that referenced this pull request Feb 4, 2025
@agithomas
Add AWS ELB add support for ALPN policy details in NLB logs (#11706)
363f858 
* Add AWS ELB add support for ALPN policy details in NLB logs
@agithomas agithomas deleted the issue-11587-backport branch February 12, 2025 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport bugfix Pull request that fixes a bug issue Integration:aws AWS Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations]

5 participants

@agithomas @elasticmachine @zmoog @ishleenk17 @andrewkroh