[ML] integrate model download into put trained model API #95281
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Hi @hendrikmuhs, I've created a changelog YAML for you. |
| Pinging @elastic/ml-core (Team:ML) |
hendrikmuhs commented Apr 17, 2023
| private void triggerModelFetchIfNecessary( | ||
| String modelId, | ||
| ModelPackageConfig modelPackageConfig, | ||
| boolean waitForCompletion, |
There was a problem hiding this comment.
waitForCompletion still misses some parts in the package loader code. I will do them in a separate PR.
| @elasticmachine update branch |
droberts195 approved these changes Apr 17, 2023
.../ml/src/test/java/org/elasticsearch/xpack/ml/action/TransportPutTrainedModelActionTests.java Outdated Show resolved Hide resolved
Co-authored-by: David Roberts <dave.roberts@elastic.co>
hendrikmuhs added the auto-merge-without-approval 
davidkyle reviewed Apr 17, 2023
...lugin/ml/src/main/java/org/elasticsearch/xpack/ml/action/TransportPutTrainedModelAction.java Show resolved Hide resolved
Co-authored-by: David Kyle <david.kyle@elastic.co>
| @elasticmachine update branch |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This PR enables downloading packaged models from
ml-models.elastic.co, an endpoint provided by Elastic. Elastic provided models begin with a., which is a private namespace that does not interfere with user models(the.prefix is disallowed for them). If a user puts a packaged model, the model gets automatically downloaded. For air-gapped environments it is possible to load models from a file.earlier changes: #95175, #95207