Skip to content

Conversation

davidkyle
Copy link
Member

The wait_for_completion query parameter was first added in elastic/elasticsearch#95281

Copy link
Contributor

Following you can find the validation results for the API you have changed.

API Status Request Response
ml.put_trained_model 🔴 14/15 6/15

You can validate this API yourself by using the make validate target.

Copy link
Contributor

@jonathan-buttner jonathan-buttner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@szabosteve could we update the elasticsearch docs with the wait_for_completion parameter for creating a trained model as well?

@szabosteve
Copy link
Contributor

szabosteve commented Mar 26, 2024

@jonathan-buttner Yes, @davidkyle is already ahead of the game: elastic/elasticsearch#106769

@davidkyle davidkyle merged commit e249b32 into main Mar 27, 2024
@davidkyle davidkyle deleted the wait-for-download branch March 27, 2024 09:01
Copy link
Contributor

The backport to 8.8 failed:

The process '/usr/bin/git' failed with exit code 1 

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub git fetch # Create a new working tree git worktree add .worktrees/backport-8.8 8.8 # Navigate to the new working tree cd .worktrees/backport-8.8 # Create a new branch git switch --create backport-2466-to-8.8 # Cherry-pick the merged commit of this pull request and resolve the conflicts git cherry-pick -x --mainline 1 e249b329112257ff298125e0ac781140d2b2250f # Push it to GitHub git push --set-upstream origin backport-2466-to-8.8 # Go back to the original working tree cd ../.. # Delete the working tree git worktree remove .worktrees/backport-8.8

Then, create a pull request where the base branch is 8.8 and the compare/head branch is backport-2466-to-8.8.

Copy link
Contributor

The backport to 8.9 failed:

The process '/usr/bin/git' failed with exit code 1 

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub git fetch # Create a new working tree git worktree add .worktrees/backport-8.9 8.9 # Navigate to the new working tree cd .worktrees/backport-8.9 # Create a new branch git switch --create backport-2466-to-8.9 # Cherry-pick the merged commit of this pull request and resolve the conflicts git cherry-pick -x --mainline 1 e249b329112257ff298125e0ac781140d2b2250f # Push it to GitHub git push --set-upstream origin backport-2466-to-8.9 # Go back to the original working tree cd ../.. # Delete the working tree git worktree remove .worktrees/backport-8.9

Then, create a pull request where the base branch is 8.9 and the compare/head branch is backport-2466-to-8.9.

Copy link
Contributor

The backport to 8.10 failed:

The process '/usr/bin/git' failed with exit code 1 

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub git fetch # Create a new working tree git worktree add .worktrees/backport-8.10 8.10 # Navigate to the new working tree cd .worktrees/backport-8.10 # Create a new branch git switch --create backport-2466-to-8.10 # Cherry-pick the merged commit of this pull request and resolve the conflicts git cherry-pick -x --mainline 1 e249b329112257ff298125e0ac781140d2b2250f # Push it to GitHub git push --set-upstream origin backport-2466-to-8.10 # Go back to the original working tree cd ../.. # Delete the working tree git worktree remove .worktrees/backport-8.10

Then, create a pull request where the base branch is 8.10 and the compare/head branch is backport-2466-to-8.10.

Copy link
Contributor

The backport to 8.11 failed:

The process '/usr/bin/git' failed with exit code 1 

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub git fetch # Create a new working tree git worktree add .worktrees/backport-8.11 8.11 # Navigate to the new working tree cd .worktrees/backport-8.11 # Create a new branch git switch --create backport-2466-to-8.11 # Cherry-pick the merged commit of this pull request and resolve the conflicts git cherry-pick -x --mainline 1 e249b329112257ff298125e0ac781140d2b2250f # Push it to GitHub git push --set-upstream origin backport-2466-to-8.11 # Go back to the original working tree cd ../.. # Delete the working tree git worktree remove .worktrees/backport-8.11

Then, create a pull request where the base branch is 8.11 and the compare/head branch is backport-2466-to-8.11.

github-actions bot pushed a commit that referenced this pull request Mar 27, 2024
github-actions bot pushed a commit that referenced this pull request Mar 27, 2024
davidkyle added a commit that referenced this pull request Mar 27, 2024
(cherry picked from commit e249b32) Co-authored-by: David Kyle <david.kyle@elastic.co>
davidkyle added a commit that referenced this pull request Mar 27, 2024
(cherry picked from commit e249b32) Co-authored-by: David Kyle <david.kyle@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment