Remove needless forking in TransportPutFollowAction #91405
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Now that elastic#87235 makes the Ccr repository non-blocking, there's no need to fork in this action just like we don't fork in a normal restore operation.
original-brownbear added >non-issue :Distributed Indexing/CCR 
elasticsearchmachine added the Team:Distributed (Obsolete) 
| Pinging @elastic/es-distributed (Team:Distributed) |
| Thanks David! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Now that #87235 makes the Ccr repository non-blocking, there's no need to fork in this action just like we don't fork in a normal restore operation.
This also make the API more nicely responsive on a master that may have a busy SNAPSHOT pool.