Remove some blocking in CcrRepository #87235
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Today `CcrRepository#getRepositoryData` blocks the calling thread pending receipt of the full metadata of the remote cluster. It would be preferable if it didn't get the full cluster metadata at all, but we can at least remove the blocking wait here.
DaveCTurner added >bug WIP :Distributed Indexing/CCR 
elasticmachine added the Team:Distributed (Obsolete) 
| Pinging @elastic/es-distributed (Team:Distributed) |
DaveCTurner added a commit to DaveCTurner/elasticsearch that referenced this pull request Jun 1, 2022
Today `CcrRepository#getRepositoryData` blocks the calling thread pending receipt of the full metadata of the remote cluster. It would be preferable if it didn't get the full cluster metadata at all, but we can at least remove the blocking wait here.
💔 Backport failed
You can use sqren/backport to manually backport by running |
DaveCTurner added a commit to DaveCTurner/elasticsearch that referenced this pull request Jun 1, 2022
Today `CcrRepository#getRepositoryData` blocks the calling thread pending receipt of the full metadata of the remote cluster. It would be preferable if it didn't get the full cluster metadata at all, but we can at least remove the blocking wait here.
DaveCTurner added a commit to DaveCTurner/elasticsearch that referenced this pull request Jun 1, 2022
Today `CcrRepository#getRepositoryData` blocks the calling thread pending receipt of the full metadata of the remote cluster. It would be preferable if it didn't get the full cluster metadata at all, but we can at least remove the blocking wait here.
elasticsearchmachine pushed a commit that referenced this pull request Jun 1, 2022
Today `CcrRepository#getRepositoryData` blocks the calling thread pending receipt of the full metadata of the remote cluster. It would be preferable if it didn't get the full cluster metadata at all, but we can at least remove the blocking wait here.
elasticsearchmachine pushed a commit that referenced this pull request Jun 1, 2022
Today `CcrRepository#getRepositoryData` blocks the calling thread pending receipt of the full metadata of the remote cluster. It would be preferable if it didn't get the full cluster metadata at all, but we can at least remove the blocking wait here.
elasticsearchmachine pushed a commit that referenced this pull request Jun 1, 2022
Today `CcrRepository#getRepositoryData` blocks the calling thread pending receipt of the full metadata of the remote cluster. It would be preferable if it didn't get the full cluster metadata at all, but we can at least remove the blocking wait here.
original-brownbear added a commit to original-brownbear/elasticsearch that referenced this pull request Nov 8, 2022
We run the same request back to back for each put-follower call during the restore. Also, concurrent put-follower calls will all run the same full CS request concurrently. In older versions prior to elastic#87235 the concurrency was limited by the size of the snapshot pool. With that fix though, they are run at almost arbitry concurrency when many put-follow requests are executed concurrently. -> fixed by using the existing deduplicator to only run a single remote CS request at a time for each CCR repository. Also, this removes the needless forking in the put-follower action that is not necessary any longer now that we have the CCR repository non-blocking (we do the same for normal restores that can safely be started from a transport thread), which should fix some bad-ux situations where the snapshot threads are busy on master, making the put-follower requests not go through in time.
original-brownbear added a commit to original-brownbear/elasticsearch that referenced this pull request Nov 8, 2022
Now that elastic#87235 makes the Ccr repository non-blocking, there's no need to fork in this action just like we don't fork in a normal restore operation.
original-brownbear added a commit that referenced this pull request Nov 17, 2022
Now that #87235 makes the Ccr repository non-blocking, there's no need to fork in this action just like we don't fork in a normal restore operation.
original-brownbear added a commit that referenced this pull request Nov 20, 2022
We run the same request back to back for each put-follower call during the restore. Also, concurrent put-follower calls will all run the same full CS request concurrently. In older versions prior to #87235 the concurrency was limited by the size of the snapshot pool. With that fix though, they are run at almost arbitry concurrency when many put-follow requests are executed concurrently. -> fixed by using the existing deduplicator to only run a single remote CS request at a time for each CCR repository. Also, this removes the needless forking in the put-follower action that is not necessary any longer now that we have the CCR repository non-blocking (we do the same for normal restores that can safely be started from a transport thread), which should fix some bad-ux situations where the snapshot threads are busy on master, making the put-follower requests not go through in time.
original-brownbear added a commit to original-brownbear/elasticsearch that referenced this pull request Apr 19, 2023
We run the same request back to back for each put-follower call during the restore. Also, concurrent put-follower calls will all run the same full CS request concurrently. In older versions prior to elastic#87235 the concurrency was limited by the size of the snapshot pool. With that fix though, they are run at almost arbitry concurrency when many put-follow requests are executed concurrently. -> fixed by using the existing deduplicator to only run a single remote CS request at a time for each CCR repository. Also, this removes the needless forking in the put-follower action that is not necessary any longer now that we have the CCR repository non-blocking (we do the same for normal restores that can safely be started from a transport thread), which should fix some bad-ux situations where the snapshot threads are busy on master, making the put-follower requests not go through in time.
elasticsearchmachine pushed a commit that referenced this pull request Apr 19, 2023
We run the same request back to back for each put-follower call during the restore. Also, concurrent put-follower calls will all run the same full CS request concurrently. In older versions prior to #87235 the concurrency was limited by the size of the snapshot pool. With that fix though, they are run at almost arbitry concurrency when many put-follow requests are executed concurrently. -> fixed by using the existing deduplicator to only run a single remote CS request at a time for each CCR repository. Also, this removes the needless forking in the put-follower action that is not necessary any longer now that we have the CCR repository non-blocking (we do the same for normal restores that can safely be started from a transport thread), which should fix some bad-ux situations where the snapshot threads are busy on master, making the put-follower requests not go through in time.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Today
CcrRepository#getRepositoryDatablocks the calling threadpending receipt of the full metadata of the remote cluster. It would be
preferable if it didn't get the full cluster metadata at all, but we can
at least remove the blocking wait here.