Improve efficiency of Grok circular reference check #74814
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This change is a tweak to elastic#74581 which removes the N^2 loop that was added in that PR.
droberts195 added :Data Management/Ingest Node 
| Pinging @elastic/es-core-features (Team:Core/Features) |
| We need to decide if the problem being fixed here will cause enough problems that it warrants being a blocker for 7.13.3 and 6.8.17. If so then it can be backported further and relabelled |
| See #74810 (comment) for timings that show the effect of this. |
danhermann approved these changes Jul 1, 2021
There was a problem hiding this comment.
LGTM. Can't be backported to 7.14 until #74829 completes which has been delayed by a number of Jenkins issues.
| 👍 Thanks for tracking this down, Robert. |
droberts195 pushed a commit that referenced this pull request Jul 1, 2021
This change is a tweak to #74581 which removes the N^2 loop that was added in that PR.
droberts195 pushed a commit that referenced this pull request Jul 1, 2021
This change is a tweak to #74581 which removes the N^2 loop that was added in that PR.
danhermann pushed a commit to danhermann/elasticsearch that referenced this pull request Jul 1, 2021
This change is a tweak to elastic#74581 which removes the N^2 loop that was added in that PR.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This change is a tweak to #74581 which removes the N^2
loop that was added in that PR.
Fixes #74810