[7.14] Improve circular reference detection in grok processor (#74581) #74829
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
danhermann added >bug :Data Management/Ingest Node 
| Pinging @elastic/es-core-features (Team:Core/Features) |
| @elasticmachine test this please |
| @elasticmachine update branch |
| @elasticmachine run elasticsearch-ci/bwc |
| @elasticmachine run elasticsearch-ci/part-2 |
| The test that's repeatedly failing in It might be simplest just to incorporate the fix into this PR: |
This change is a tweak to elastic#74581 which removes the N^2 loop that was added in that PR.
…nn/elasticsearch into backport_714_74581_grok
| All tests passed. Some test result updates on the PR were delayed. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Certain combinations of patterns could result in circular references that were not properly detected. This PR resolves that.
Backport of #74581