Initial implementation of random sampling #135660
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
masseyke added >non-issue :Data Management/Ingest Node 
elasticsearchmachine added the Team:Data Management 
| Pinging @elastic/es-data-management (Team:Data Management) |
seanzatzdev requested changes Sep 30, 2025
server/src/main/java/org/elasticsearch/ingest/SamplingService.java Outdated Show resolved Hide resolved
server/src/main/java/org/elasticsearch/ingest/SamplingService.java Outdated Show resolved Hide resolved
server/src/main/java/org/elasticsearch/ingest/SamplingService.java Outdated Show resolved Hide resolved
There was a problem hiding this comment.
Pull Request Overview
This PR implements the core random sampling functionality for Elasticsearch behind a feature flag, focusing on the sampling logic and statistics collection without REST API endpoints.
- Adds complete sampling implementation with support for rates, conditional scripts, max samples, and statistics
- Implements memory-efficient storage using SoftReferences to prevent memory issues
- Provides comprehensive test coverage for all sampling scenarios and edge cases
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| SamplingService.java | Core implementation with sampling logic, statistics tracking, and data structures |
| SamplingServiceTests.java | Comprehensive unit tests covering sampling scenarios, conditions, and limits |
| SamplingServiceSampleStatsTests.java | Tests for statistics serialization and combination logic |
| SamplingServiceRawDocumentTests.java | Tests for raw document serialization and mutation |
| NodeConstruction.java | Updates service construction to include required dependencies |
| IngestService.java | Simplifies sampling integration by removing unnecessary IndexRequest copying |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
server/src/main/java/org/elasticsearch/ingest/SamplingService.java Outdated Show resolved Hide resolved
server/src/test/java/org/elasticsearch/ingest/SamplingServiceSampleStatsTests.java Outdated Show resolved Hide resolved
server/src/test/java/org/elasticsearch/ingest/SamplingServiceRawDocumentTests.java Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This builds on #134766 and #134585, adding the logic to perform random sampling. For now, it is only tested via unit tests because there is no REST API yet to create a sampling configuration, or to retrieve a sample. Those are coming up next.
This implements the basics of sampling behind a feature flag, including:
It does not yet support the following, which will come in subsequent PRs: