Adding the shell of the SamplingService #134766
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
masseyke added >non-issue :Data Management/Ingest Node 
elasticsearchmachine added the Team:Data Management 
| Pinging @elastic/es-data-management (Team:Data Management) |
seanzatzdev reviewed Sep 16, 2025
server/src/main/java/org/elasticsearch/action/bulk/TransportAbstractBulkAction.java Outdated Show resolved Hide resolved
seanzatzdev approved these changes Sep 16, 2025
| LGTM! |
seanzatzdev approved these changes Sep 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This is the shell of the future SamplingService, which will have the logic for configuring random sampling of raw documents, as well as doing the sampling, and returning samples.
For now, this is no-op, with tests to make sure that
maybeSampleis appropriately called from TransportBulkAction and IngestService. Future PRs will add more functionality. See #134233 for a prototype.