- Notifications
You must be signed in to change notification settings - Fork 195
EDOT collector: include the forward connector. #8753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EDOT collector: include the forward connector. #8753
Conversation
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed forwardconnector seems that it does the trick, so LGTM. Only one minor thingie @cmacknz please run mage fmt
and repush 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks ok, I wonder if the new component should be listed in internal/pkg/otel/core-components.yaml
as introduced by PR #8530
Holding off approval till CI is green
Core components means users can open SDHs against them and we'll try to fix them. I don't think we we are at the point where we need that for the foward connector as we don't depend on it for anything yet. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
|
💚 Build Succeeded
History
cc @cmacknz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* EDOT collector: include the forward connector. https://github.com/open-telemetry/opentelemetry-collector/tree/main/connector/forwardconnector * Add changelog. * mage fmt. * Add forward connector to all-components.yml (cherry picked from commit 393e2ed)
* EDOT collector: include the forward connector. https://github.com/open-telemetry/opentelemetry-collector/tree/main/connector/forwardconnector * Add changelog. * mage fmt. * Add forward connector to all-components.yml (cherry picked from commit 393e2ed)
* EDOT collector: include the forward connector. https://github.com/open-telemetry/opentelemetry-collector/tree/main/connector/forwardconnector * Add changelog. * mage fmt. * Add forward connector to all-components.yml (cherry picked from commit 393e2ed) Co-authored-by: Craig MacKenzie <craig.mackenzie@elastic.co>
* EDOT collector: include the forward connector. https://github.com/open-telemetry/opentelemetry-collector/tree/main/connector/forwardconnector * Add changelog. * mage fmt. * Add forward connector to all-components.yml (cherry picked from commit 393e2ed) Co-authored-by: Craig MacKenzie <craig.mackenzie@elastic.co>
…ng-oblt-cli * upstream: (37 commits) [AutoOps] Add `autoops-es.yml` to Packages (elastic#8728) EDOT collector: include the forward connector. (elastic#8753) Revert "ci: pin elastic-agent version (elastic#8736)" (elastic#8754) bk: retry Start ESS stack for integration tests (elastic#8553) Re-enable TestStandaloneUpgradeRollbackOnRestarts on windows (elastic#8718) removed reviewers from dependabot.yml (elastic#8709) Pass `--header` enrollment option to fleet-server (elastic#8071) Add ability for local output configuration to add to policy configuration (elastic#8766) Bump up github.com/go-viper/mapstructure/v2 dependency (elastic#8764) [Synthetics] Upgrade node to latest lts v20 (elastic#8712) [CI] BK Vault plugin for EC access (elastic#8377) feat: singleTest mage target for each integration test package (elastic#8691) ci: always include 8.19 LTS release branch in snapshots of test versions (elastic#8761) build(deps): bump github.com/elastic/mito from 1.19.0 to 1.20.0 (elastic#8755) chore: fix elastic-agent helm chart examples (elastic#8765) feat: support onboarding-id for kubernetes (elastic#8692) [main][Automation] Bump VM Image version to 1751072471 (elastic#8734) ci: revert deployment_csp_configuration.yaml to create_deployment_csp_configuration.yaml (elastic#8746) kustomize: pin kube-state-metrics version (elastic#8739) ci: pin elastic-agent version (elastic#8736) ...
* upstream: (39 commits) Fix otel extension status reporting (#8696) Refactor user change on service (#8347) [AutoOps] Add `autoops-es.yml` to Packages (#8728) EDOT collector: include the forward connector. (#8753) Revert "ci: pin elastic-agent version (#8736)" (#8754) bk: retry Start ESS stack for integration tests (#8553) Re-enable TestStandaloneUpgradeRollbackOnRestarts on windows (#8718) removed reviewers from dependabot.yml (#8709) Pass `--header` enrollment option to fleet-server (#8071) Add ability for local output configuration to add to policy configuration (#8766) Bump up github.com/go-viper/mapstructure/v2 dependency (#8764) [Synthetics] Upgrade node to latest lts v20 (#8712) [CI] BK Vault plugin for EC access (#8377) feat: singleTest mage target for each integration test package (#8691) ci: always include 8.19 LTS release branch in snapshots of test versions (#8761) build(deps): bump github.com/elastic/mito from 1.19.0 to 1.20.0 (#8755) chore: fix elastic-agent helm chart examples (#8765) feat: support onboarding-id for kubernetes (#8692) [main][Automation] Bump VM Image version to 1751072471 (#8734) ci: revert deployment_csp_configuration.yaml to create_deployment_csp_configuration.yaml (#8746) ...
https://github.com/open-telemetry/opentelemetry-collector/tree/main/connector/forwardconnector
Include the forwardconnector, which we are highly likely to need for OTel native integrations to allow for unique processors per receiver without having to have unique pipelines with duplicate exporters.
To test this PR I used the following configuration showing how to have 2 filelog receivers that could have separate processors applied but export via the same exporter.