- Notifications
You must be signed in to change notification settings - Fork 197
Add components YAML file with Core and Extended info #8530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This pull request does not have a backport label. Could you fix it @theletterf? 🙏
|
It'd be best if we could add a test that verifies all the components we ship in EDOT are present in this file. That doesn't need to happen in this PR if you're not up to it @theletterf, but then we should file a follow-up issue. |
@swiatekm @AlexanderWert I've created a simple test that uses the same strategy and the current docs automation, that is, reading go.mod. Probably not as elegant as using Factories, but it works. |
Co-authored-by: Paolo Chilà <paolo.chila@elastic.co>
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of suggestions for asserting the absence of errors (non-blocking)
As a more general question: @swiatekm was talking about a test that would ensure that all the components we ship in EDOT would appear in the file, while the test checks that go.mod contains the component listed in the file (the inclusion is reversed). Which condition we want to maintain here ?
Co-authored-by: Paolo Chilà <paolo.chila@elastic.co>
Co-authored-by: Paolo Chilà <paolo.chila@elastic.co>
@pchila See #8530 (comment) for the rationale on why we're testing things this way. |
@pchila Fine if we skip CI / tests for this one? |
I am afraid we have to wait for the CI to finish after the last merge 😓 |
💚 Build Succeeded
History
cc @theletterf |
|
* Add components YAML file with Core and Extended info * Rename file * Add test * Format * Update internal/pkg/otel/core_components_test.go Co-authored-by: Paolo Chilà <paolo.chila@elastic.co> * Simplify test * Format * Update internal/pkg/otel/core_components_test.go Co-authored-by: Paolo Chilà <paolo.chila@elastic.co> * Update internal/pkg/otel/core_components_test.go Co-authored-by: Paolo Chilà <paolo.chila@elastic.co> * Fix missing quotes --------- Co-authored-by: Paolo Chilà <paolo.chila@elastic.co> (cherry picked from commit 21aa2ac)
* Add components YAML file with Core and Extended info * Rename file * Add test * Format * Update internal/pkg/otel/core_components_test.go * Simplify test * Format * Update internal/pkg/otel/core_components_test.go * Update internal/pkg/otel/core_components_test.go * Fix missing quotes --------- (cherry picked from commit 21aa2ac) Co-authored-by: Fabrizio Ferri-Benedetti <algernon@fastmail.com> Co-authored-by: Paolo Chilà <paolo.chila@elastic.co>
This adds a manual components.yaml file to map the support status of each EDOT Collector components: Core or Extended. This is necessary to properly render the automated table in the docs: https://www.elastic.co/docs/reference/opentelemetry/edot-collector/components
See: https://www.elastic.co/docs/reference/opentelemetry/compatibility/nomenclature#core-components
More context: