- Notifications
You must be signed in to change notification settings - Fork 539
[8.6] fix: cast event.duration to long in event_duration pipeline (backport #9901) #9910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
* fix: cast event.duration to long in event_duration pipeline The otel span start/end dates are used to compute the event duration of the APM event, stored as a time.Duration. The duration is converted to nanoseconds stored in an int64 field, however the values is casted to int in the event_duration pipeline leading to an overflow if the original 64 bit value cannot be casted safely to the 32-bit int. * test: update otlp system-test to validate duration overflow fix * changelog: add changelog entry (cherry picked from commit f6872f4) # Conflicts: # apmpackage/apm/changelog.yml
kruskall reviewed Dec 28, 2022
Contributor Author
| This pull request has not been merged yet. Could you please review and merge it @kruskall? 🙏 |
8.6 is not released yet, do not use the explicit version in the changelog file.
📚 Go benchmark reportDiff with the report generated with https://pkg.go.dev/golang.org/x/perf/cmd/benchstat |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #9901 done by Mergify.
Cherry-pick of f6872f4 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com