fix: cast event.duration to long in event_duration pipeline #9901
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
The otel span start/end dates are used to compute the event duration of the APM event, stored as a time.Duration. The duration is converted to nanoseconds stored in an int64 field, however the values is casted to int in the event_duration pipeline leading to an overflow if the original 64 bit value cannot be casted safely to the 32-bit int.
kruskall changed the title 
Contributor
| This pull request does not have a backport label. Could you fix it @kruskall? 🙏
NOTE: |
mergify bot added the backport-skip 
marclop approved these changes Dec 28, 2022
Contributor
marclop left a comment
marclop left a comment There was a problem hiding this comment.
Looks good, thanks for the quick fix. We should backport to 8.6 as well
mergify bot removed the backport-skip 
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
📚 Go benchmark reportDiff with the report generated with https://pkg.go.dev/golang.org/x/perf/cmd/benchstat |
lahsivjar approved these changes Dec 28, 2022
Contributor
lahsivjar left a comment
lahsivjar left a comment There was a problem hiding this comment.
LGTM other than the changelog entry Marc mentioned earlier.
Contributor
| This pull request is now in conflicts. Could you fix it @kruskall? 🙏 |
Member Author
| @marclop Added a changelog. Thanks for mentioning that! 🙇 |
carsonip approved these changes Dec 28, 2022
marclop approved these changes Dec 28, 2022
mergify bot pushed a commit that referenced this pull request Dec 28, 2022
* fix: cast event.duration to long in event_duration pipeline The otel span start/end dates are used to compute the event duration of the APM event, stored as a time.Duration. The duration is converted to nanoseconds stored in an int64 field, however the values is casted to int in the event_duration pipeline leading to an overflow if the original 64 bit value cannot be casted safely to the 32-bit int. * test: update otlp system-test to validate duration overflow fix * changelog: add changelog entry (cherry picked from commit f6872f4) # Conflicts: # apmpackage/apm/changelog.yml
kruskall added a commit that referenced this pull request Dec 29, 2022
…ckport #9901) (#9910) * fix: cast event.duration to long in event_duration pipeline (#9901) * fix: cast event.duration to long in event_duration pipeline The otel span start/end dates are used to compute the event duration of the APM event, stored as a time.Duration. The duration is converted to nanoseconds stored in an int64 field, however the values is casted to int in the event_duration pipeline leading to an overflow if the original 64 bit value cannot be casted safely to the 32-bit int. * test: update otlp system-test to validate duration overflow fix * changelog: add changelog entry (cherry picked from commit f6872f4) # Conflicts: # apmpackage/apm/changelog.yml * changelog: fix conflict and add 8.6 changelog * changelog: fix changelog version 8.6 is not released yet, do not use the explicit version in the changelog file. Co-authored-by: kruskall <99559985+kruskall@users.noreply.github.com>
| do we have the above fix backport to 8.4 version? |
Contributor
| The bug fix will be part of |
| is there ETA for 8.6 release? we are waiting on this feature to have proper data from open-telemetry for Jenkins pipelines |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Motivation/summary
The otel span start/end dates are used to compute the event
duration of the APM event, stored as a time.Duration.
The duration is converted to nanoseconds stored in an int64
field, however the values is casted to int in the event_duration
pipeline leading to an overflow if the original 64 bit value
cannot be casted safely to the 32-bit int.
Checklist
apmpackagehave been made)For functional changes, consider:
How to test these changes
Related issues
Closes #9780