Skip to content

use "unknown-python-service" as default service name #1438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 5, 2022
Merged

use "unknown-python-service" as default service name #1438

merged 2 commits into from
Jan 5, 2022

Conversation

beniwohli
Copy link
Contributor

closes #1425
@ghost
Copy link

ghost commented Dec 21, 2021 •
edited by ghost
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-12-21T10:29:18.967+0000

  • Duration: 35 min 50 sec

  • Commit: b5b0896

Test stats 🧪

Test Results
Failed 0
Passed 10261
Skipped 9603
Total 19864

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /test linters : Run the Python linters only.

  • /test full : Run the full matrix of tests.

  • /test benchmark : Run the APM Agent Python benchmarks tests.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)
@beniwohli beniwohli merged commit 3da9f2d into elastic:master Jan 5, 2022
@beniwohli beniwohli deleted the fix-1425 branch January 5, 2022 14:33
basepi added a commit to basepi/apm-agent-python that referenced this pull request May 10, 2022
@basepi
Log error for empty SERVICE_NAME
8938aab 
Also fixed up the default service name handling for the new default set in elastic#1438
@basepi basepi mentioned this pull request May 10, 2022
Merged
basepi added a commit that referenced this pull request May 11, 2022
@basepi
Log error for empty SERVICE_NAME (#1546)
4b2eb86 
* Log error for empty SERVICE_NAME Also fixed up the default service name handling for the new default set in #1438 * Use .strip() to check for whitespace SERVICE_NAME Also CHANGELOG * Clarify that SERVICE_NAME must not be whitespace-only
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agent-python
1 participant
@beniwohli