Skip to content

Commit 3da9f2d

Browse files
authored
use "unknown-python-service" as default service name (#1438)
* use "unknown-python-service" as default service name closes #1425 * update changelog
1 parent 528d178 commit 3da9f2d

File tree

3 files changed

+8
-5
lines changed

3 files changed

+8
-5
lines changed

CHANGELOG.asciidoc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,8 @@ endif::[]
2727
//
2828
//
2929
[float]
30-
===== Bug fixes
31-
* fix AttributeError in sync instrumentation of httpx {pull}1423[1423]
30+
===== Features
31+
* use "unknown-python-service" as default service name if no service name is configured {pull}1438[#1438]
3232
3333
3434
[[release-notes-6.x]]

docs/configuration.asciidoc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -86,8 +86,8 @@ apm = ElasticAPM(app)
8686

8787
[options="header"]
8888
|============
89-
| Environment | Django/Flask | Default | Example
90-
| `ELASTIC_APM_SERVICE_NAME` | `SERVICE_NAME` | `python_service` | `my-app`
89+
| Environment | Django/Flask | Default | Example
90+
| `ELASTIC_APM_SERVICE_NAME` | `SERVICE_NAME` | `unknown-python-service` | `my-app`
9191
|============
9292

9393

elasticapm/conf/__init__.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -509,7 +509,10 @@ def copy(self):
509509

510510
class Config(_ConfigBase):
511511
service_name = _ConfigValue(
512-
"SERVICE_NAME", validators=[RegexValidator("^[a-zA-Z0-9 _-]+$")], default="python_service", required=True
512+
"SERVICE_NAME",
513+
validators=[RegexValidator("^[a-zA-Z0-9 _-]+$")],
514+
default="unknown-python-service",
515+
required=True,
513516
)
514517
service_node_name = _ConfigValue("SERVICE_NODE_NAME")
515518
environment = _ConfigValue("ENVIRONMENT")

0 commit comments

Comments
 (0)