Skip to content

Fix AttributeError in sync httpx instrumentation #1423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 3, 2021
Merged

Fix AttributeError in sync httpx instrumentation #1423

merged 4 commits into from
Dec 3, 2021

Conversation

HenrikOssipoff
Copy link
Contributor

@HenrikOssipoff HenrikOssipoff commented Dec 1, 2021 •
edited
Loading

What does this pull request do?

#1403 introduced a breaking change due to a refactor. This should make the sync code in line with the async version and fix the AttributeError.

Related issues

closes #1422
@github-actions github-actions bot added agent-python community Issues opened by the community triage Issues awaiting triage labels Dec 1, 2021
@ghost
Copy link

ghost commented Dec 1, 2021 •
edited by ghost
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-12-03T16:21:46.995+0000

  • Duration: 34 min 18 sec

  • Commit: 10020e6

Test stats 🧪

Test Results
Failed 0
Passed 10245
Skipped 9603
Total 19848

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /test linters : Run the Python linters only.

  • /test full : Run the full matrix of tests.

  • /test benchmark : Run the APM Agent Python benchmarks tests.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)
@basepi
Copy link
Contributor

basepi commented Dec 3, 2021

Thank you for spotting and fixing this!
@basepi
Copy link
Contributor

basepi commented Dec 3, 2021

/test
@basepi basepi self-assigned this Dec 3, 2021
@basepi basepi removed the triage Issues awaiting triage label Dec 3, 2021
@basepi
Copy link
Contributor

basepi commented Dec 3, 2021

/test
@basepi basepi merged commit 3b16d8c into elastic:master Dec 3, 2021
@HenrikOssipoff HenrikOssipoff deleted the fix-httpx-instrumentation branch December 3, 2021 18:16
beniwohli pushed a commit that referenced this pull request Dec 7, 2021
@HenrikOssipoff @basepi @beniwohli
Fix AttributeError in sync httpx instrumentation (#1423)
5040a52 
* Fix AttributeError in sync httpx instrumentation Closes 1422 * Link PR Co-authored-by: Colton Myers <colton.myers@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agent-python community Issues opened by the community
2 participants
@HenrikOssipoff @basepi