Skip to content

Conversation

beniwohli
Copy link
Contributor

@beniwohli beniwohli commented Nov 16, 2021

httpx 0.21 and httpcore 0.14 once again changed how it works,
necessitating more special handling. To make this a tad less
cumbersome, most of this code has moved into a utils file.
To make the structure somewhat sane, httpx got its own
package in instrumentation.

closes #1399
closes #1400
closes #1401

httpx 0.21 and httpcore 0.14 once again changed how it works, necessitating more special handling. To make this a tad less cumbersome, most of this code has moved into a utils file. To make the structure somewhat sane, httpx got its own package in instrumentation
@ghost
Copy link

ghost commented Nov 16, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-11-16T16:58:55.103+0000

  • Duration: 32 min 6 sec

  • Commit: b75420f

Test stats 🧪

Test Results
Failed 0
Passed 10287
Skipped 9537
Total 19824

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /test linters : Run the Python linters only.

  • /test full : Run the full matrix of tests.

  • /test benchmark : Run the APM Agent Python benchmarks tests.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@beniwohli
Copy link
Contributor Author

/test full

2 similar comments
@kuisathaverat
Copy link
Contributor

/test full

@kuisathaverat
Copy link
Contributor

/test full

@beniwohli
Copy link
Contributor Author

/test full

@beniwohli
Copy link
Contributor Author

full test matrix was built with the exception of some Python 3.8 runs which were aborted for some reason. It passed for all other CPython versions, so the abort was probably unrelated.

Copy link
Contributor

@basepi basepi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good simplification in addition to fixing compat. 👍

@basepi basepi merged commit 33adb7d into elastic:master Nov 16, 2021
@beniwohli beniwohli deleted the fix-httpx-again branch November 16, 2021 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants