Check WebView capabilities when determining if bookmark import possible #7037
+54 −2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
16 tasks
This stack of pull requests is managed by Graphite. Learn more about stacking. |
cmonfortep approved these changes Oct 30, 2025
| override suspend fun getBookmarksImportLaunchIntent(): Intent? { | ||
| return withContext(dispatchers.io()) { | ||
| if (autofillFeature.canImportBookmarksFromGoogleTakeout().isEnabled()) { | ||
| if (autofillFeature.canImportBookmarksFromGoogleTakeout().isEnabled() && webViewCapabilityChecker.webViewCapableOfImporting()) { |
There was a problem hiding this comment.
It's cool we can put the check here 👍
Merge activity
|
CDRussell changed the base branch from feature/craig/bookmark_import_flow_observability to graphite-base/7037 CDRussell force-pushed the feature/craig/web_view_capability_checks_for_bookmark_import branch from a200bdb to 1b2488a Compare CDRussell deleted the feature/craig/web_view_capability_checks_for_bookmark_import branch Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/1/137249556945/project/488551667048375/task/1211794988737145?focus=true
Description
Adds WebView capability checks when determining if bookmark importing is possible
Steps to test this PR
ℹ️ QA optional
Webviewand tap onImport Bookmarksbutton insideBookmarksactivity. Verify it launches straight into the "old" flow to choose a file to import directly (no dialog, no offer to do the web flow)