Bookmark import flow observability #7007
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
CDRussell force-pushed the feature/craig/bookmark_import_flow_observability branch 2 times, most recently from 53a9493 to 4b6121a Compare 
CDRussell commented Oct 28, 2025
Comment on lines +35 to +45
| return when (seconds) { | ||
| in 0..19 -> "20" | ||
| in 20..39 -> "40" | ||
| in 40..59 -> "60" | ||
| in 60..89 -> "90" | ||
| in 90..119 -> "120" | ||
| in 120..149 -> "150" | ||
| in 150..179 -> "180" | ||
| in 180..239 -> "240" | ||
| in 240..299 -> "300" | ||
| else -> "longer" |
There was a problem hiding this comment.
the bucket values indicates the time it was completed within. e.g., 20 means it completed in less than 20s. 60 means it completed in less than 60s and so on.
| | ||
| val chromeHtmlFiles = mutableListOf<String>() | ||
| | ||
| // First pass: collect Chrome HTML files and look for Bookmarks.html |
There was a problem hiding this comment.
Need to update this so that it doesn't return early upon finding an exact match on the Takeout/Chrome/Bookmarks.html file since if there are more files in there, it is pixelled
...kduckgo/autofill/impl/importing/takeout/webflow/ImportGoogleBookmarksWebFlowViewModelTest.kt Show resolved Hide resolved
CDRussell force-pushed the feature/craig/bookmark_import_flow_observability branch from 4b6121a to 214e816 Compare 1 task
There was a problem hiding this comment.
Pull Request Overview
This PR adds comprehensive pixel tracking for the Google bookmarks import flow to measure user engagement and diagnose issues. The implementation tracks the full import journey from dialog interactions through flow completion or errors.
- Adds pixel tracking for pre-import dialog events (shown, dismissed, user actions)
- Implements journey tracking with duration bucketing for flow performance metrics
- Adds pixel for detecting multiple Chrome export files in Google Takeout
- Refactors error handling to include step information for better debugging
Reviewed Changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| ImportFromGoogleBookmarksPreImportDialog.kt | Added pixel tracking for dialog shown/dismissed and user action events; removed onCreate lifecycle override |
| SavedSitesPixelName.kt | Added 4 new pixel names for pre-import dialog tracking and configured ATB parameter removal |
| AutofillPixelNames.kt | Added 5 new pixel names for flow journey tracking (started, success, error, cancelled, extra Chrome export) |
| ImportGoogleBookmarksJourney.kt | New file implementing journey tracking with duration measurement and pixel firing |
| ImportGoogleBookmarksDurationBucketing.kt | New file implementing time bucketing logic for duration metrics |
| TakeoutBookmarkExtractor.kt | Refactored extraction logic to detect multiple Chrome files and fire pixel; improved code structure |
| ImportGoogleBookmarksWebFlowActivity.kt | Changed launch parameter from data object to data class with launchSource; integrated journey tracking |
| ImportGoogleBookmarkResult.kt | Changed WebViewError from data object to data class to include step information |
| ImportGoogleBookmarksWebFlowViewModel.kt | Added onFatalWebViewError method to handle WebView errors with step tracking |
| ImportGoogleBookmarksWebFlowFragment.kt | Updated to use new ViewModel method for WebView errors; removed unused error mapping function |
| ImportFromGoogleImpl.kt | Added getLaunchSource method to provide source for journey tracking |
| RealImportGoogleBookmarksJourneyTest.kt | New comprehensive test file for journey tracking functionality |
| RealImportGoogleBookmarksDurationBucketingTest.kt | New test file for duration bucketing logic |
| ImportGoogleBookmarksWebFlowViewModelTest.kt | Added test for WebView error handling; reformatted existing tests |
| TakeoutZipBookmarkExtractorTest.kt | Added tests for multiple Chrome file detection and pixel firing |
| ImportFromGoogleImplTest.kt | Updated mock setup to match new data class parameter type |
...in/java/com/duckduckgo/savedsites/impl/importing/ImportFromGoogleBookmarksPreImportDialog.kt Show resolved Hide resolved
...m/duckduckgo/autofill/impl/importing/takeout/webflow/ImportGoogleBookmarksWebFlowActivity.kt Show resolved Hide resolved
...l/autofill-impl/src/main/java/com/duckduckgo/autofill/impl/importing/ImportFromGoogleImpl.kt Show resolved Hide resolved
...m/duckduckgo/autofill/impl/importing/takeout/webflow/ImportGoogleBookmarksWebFlowActivity.kt Show resolved Hide resolved
cmonfortep approved these changes Oct 30, 2025
Merge activity
|
CDRussell deleted the feature/craig/bookmark_import_flow_observability branch Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/1/137249556945/project/488551667048375/task/1211724585727142?focus=true
Description
Adds observability around bookmark import flow and pre-import dialog.
Steps to test this PR
Logcat filter:
package:mine message~:"Bookmark-import: |Pixel sent: bookmark_import_from_google"Import flow (success)
Saved Site Dev SettingsLaunch Google Takeout import flowbookmark_import_from_google_flow_startedin the logs, params should match specbookmark_import_from_google_flow_success, params should match spec (e.g., correct duration buckets)Import flow (cancellation)
bookmark_import_from_google_flow_cancelledin the logs and it includes thestepReachedalongside durations.Import flow (simulate error)
bookmark_import_from_google_flow_erroranderrorReasonstarts withwebView-then has the step. (e.g.,webView-takeout-first)Pre-import dialogs
Import(from empty state or overflow; doesn't matter)bookmark_import_from_google_dialog_shownappearsbookmark_import_from_google_dialog_dismissedappearsSelect Bookmarks File; verifybookmark_import_from_google_dialog_fromfileappeasImport From Googlebutton and verifybookmark_import_from_google_dialog_startflowPatch to force a crash during import