RandomAccess.Write throws System.IO.IOException when buffers total size greater than 2GB

[NicoAvanzDev]

Fixes #108322

Description

Fixes RandomAccess.Write that throws System.IO.IOException on windows machine where the buffer is larger than 2GB

Customer Impact

Possible file corruption when writing

Regression

#108322 (comment)

Testing

Without the fix:

With the fix:

Test method

[Fact] void RandomAccessWrite_ShouldNot_Throw_IOException_When_Buffer_Larger_Than_MaxInt32() { // Arrange const long gigabyte = 1L * 1024 * 1024 * 1024; var rolist = new List<ReadOnlyMemory<byte>>(); for (int i = 0; i < 3; i++) { rolist.Add(new ReadOnlyMemory<byte>(new byte[gigabyte])); } // Act try { UnmanagedFileLoader loader = new UnmanagedFileLoader("C:\\tmp\\testfile.txt"); RandomAccess.Write(loader.Handle, rolist, 0); } catch (IOException ex) { Assert.Fail("Unable to write file" + ex.Message); } }

The actual UnmanagedFileLoader implementation can be found here from official microsoft documentation

Risk

None

Package authoring signed off?

IMPORTANT: If this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.

[adamsitnik]

LGTM, thank you for your contribution @NicoAvanzDev !

[adamsitnik]

/ba-g crypto failure is unrelated

[adamsitnik]

@jeffhandley @stephentoub once I get back from the vacations I am going to add test for it and backport it to supported versions