Handle IOV_MAX limit in RandomAccess #109340
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
ghost added the This was referenced Oct 29, 2024
am11 reviewed Oct 31, 2024
am11 reviewed Oct 31, 2024
Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>
This was referenced Oct 31, 2024
Open
stephentoub approved these changes Nov 8, 2024
Member Author
| /ba-g the failures are known, the DeadLetter was not caused by my changes |
adamsitnik added a commit to adamsitnik/runtime that referenced this pull request Nov 8, 2024
* add test for Int32 overflow for WriteGather in RandomAccess * add failing test fore more than IOV_MAX buffers * fix both the native and managed parts --------- Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com> Co-authored-by: Stephen Toub <stoub@microsoft.com>
4 tasks
adamsitnik added a commit to adamsitnik/runtime that referenced this pull request Nov 8, 2024
* add test for Int32 overflow for WriteGather in RandomAccess * add failing test fore more than IOV_MAX buffers * fix both the native and managed parts --------- Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com> Co-authored-by: Stephen Toub <stoub@microsoft.com>
4 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
We were not respecting IOV_MAX in
pwritevandpreadvexposed byRandomAccess. After writing test for it I've realized that the logic for handling the incomplete writes was also incomplete (please see the changes in managed layer).fixes #108383 and adds a test for scenario described in #108322 , so I can backport #108380 to all supported versions.