Omit key services with derived attribute from OpenAPI definitions #62946
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
stevendarby requested review from a team, captainsafia and halter73 as code owners 
github-actions bot added the area-mvc 
dotnet-policy-service bot added the community-contribution | Oops, I was slow off the mark and only just realised @martincostello already raised a PR for this. There are some more improvements to the tests than in my PR, so I'll close this. |
This was referenced Jul 26, 2025
| @stevendarby Thanks nonetheless for being willing to open a PR! 😄 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Omit key services with derived attribute from OpenAPI definitions
Instead of checking the attribute type is exactly
FromKeyedServicesAttribute, it now checks if it's assignable to it, so that it also covers derived attributes.Note, I find the relatively newer
IsAssignableToeasier to follow thanIsAssignableFromso opted for that, and in a slightly opinionated way I changed the existing code on that line to use that too, for some local consistency. I hope that's ok.Fixes #58739