Add net11 support #2911
Merged
Add net11 support #2911
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
timcassell reviewed Dec 10, 2025
Member Author
| @timcassell Do you have any idea why the CurrentRuntimeIsProperlyRecognized is still failing despite reverting it back to be teh same as master? Running locally I didn't hit the issue, but I think it was using net8.0 instead of net10.0. |
Collaborator
Because of your change in DotNetRuntimeHelper.cs. |
Member Author
| Thank you for catching this, went ahead and undid that change. |
timcassell approved these changes Dec 12, 2025
Collaborator
| Thanks @LoopedBard3 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Add net11.0 support. Based on the update for net10.0: #2642.
(Answered)
Open question: Is the update to src/BenchmarkDotNet/Toolchains/NativeAot/Generator.cs and tests/BenchmarkDotNet.Tests/Helpers/DotNetRuntimeHelper.cs correct?Once merged we plan on updating the dotnet/performance repo to latest BDN, in part for the WasmNet11_0 runtime moniker support.