Add .NET 10 support

[am11]

This strongly-typed enums based implementation is not scaling very well; but for now, lets add 10.0 and soon after lets see if we can make it less verbose to ease up future updates a bit: dotnet/runtime#106599 (comment)

cc @adamsitnik, @lewing

[caaavik-msft]

I've tested this PR against a local build from dotnet/runtime#106599 and it fails because it seems that the .NET 10 SDK doesn't actually allow to target .NET 10, rather it only allows targetting .NET 9. To get things to work we do need to make changes to the SDK validator to allow backwards compatibility. However, this change will still be useful to have in once we do have .NET 10 targeting supported

[am11]

Yup, it's a chicken-egg situation atm, and we will soon be on alpha1 in runtime repo (based on how it was done last year, around this time). I think we can pass --corerun option in local builds that points to built corerun under artifacts/bin or artifacts/tests/coreclr/<platform>/Tests/Core_Root to get the ball rolling?

[timcassell]

GitHub won't let me add a comment on the actual line... I think the TryParse method needs to be updated to account for the underscore.

internal static bool TryParse(string runtime, out RuntimeMoniker runtimeMoniker) { int index = runtime.IndexOf('-'); if (index >= 0) { runtime = runtime.Substring(0, index); } // Monikers older than Net 10 don't use any version delimiter, newer monikers use _ delimiter. if (Enum.TryParse(runtime.Replace(".", string.Empty), ignoreCase: true, out runtimeMoniker)) { return true; } return Enum.TryParse(runtime.Replace('.', '_'), ignoreCase: true, out runtimeMoniker); }

I don't have a 10.0 sdk version, so I didn't test.

[timcassell]

Suggested change

	[InlineData("net70")]
	[InlineData("net80")]
	[InlineData("net90")]
	[InlineData("net10_0")]
	[InlineData("net7.0")]
	[InlineData("net8.0")]
	[InlineData("net9.0")]
	[InlineData("net10.0")]

[am11]

IMHO the best direction would be to introduce something similar to the [SupportedOSPlatform], such as [SupportedFramework("netX.0")], which would provide indefinite scalability. The current hardcoded enum approach doesn't scale well, which was precisely why [SupportedPlatform("")] (introduced in .NET 5.0) was designed to be string-based instead of enum-based—managing an enum over the years would have been a maintenance nightmare.

This transition to .NET 10.0 might be an ideal time to consider such a change and start deprecating the old enum, with the goal of fully removing it after a few release cycles. Additionally, pseudo-TFMs like nativeaot9.0 feel somewhat unnatural compared to the broader ecosystem’s conventions, such as using net9.0 combined with --aot (e.g., dotnet new console -f net9.0 --aot) or simply setting PublishAot=true.

[timcassell]

I don't understand how [SupportedFramework("netX.0")] would be used. I think you should open an issue with more details rather than discuss it here. And/or create a WIP PR showcasing a new system.

[LoopedBard3]

I think now may be a good time to revisit this PR. Is there anything specifically blocking it or just another pass to clean up the suggested changes? We are hitting an issue for our performance wasm testing due to wasmnet100/wasmnet10_0. FYI @caaavik-msft

[LoopedBard3]

@timcassell is there anything else that needs to be done before merging this? It seems maybe the TryParse update, but wanted to check if there was anything else.

[timcassell]

I think that's the only thing. And the test cases.

[timcassell]

@LoopedBard3 Regarding wasm specifically, you could also send a PR to fix the wasm logic so you can use the simple Wasm moniker and not need to continually update the moniker every year. #2641 (comment)

[LoopedBard3]

I have a PR against the base branch for this PR here: am11#1. If @am11 accepts it or makes the changes, we should merge this, otherwise I will make a new PR tomorrow and link it back to this one.

[adamsitnik]

LGTM. Since .NET Team needs it, I am going to merge it in the current form and cherry pick changes from https://github.com/am11/BenchmarkDotNet/pull/1/files.

Thank you @am11 and others involved!

[adamsitnik]

.NET 10 is not even in Preview 1 yet so we don't have to update the templates right now. But on the other hand if we don't do it now, we may simply forget about it. So let's merge it in the current form