Skip to content

fix(metrics): remove high cardinality labels in metrics #17820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 21, 2025
+6 −13
Merged

fix(metrics): remove high cardinality labels in metrics #17820

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3e06b7d
remove metrics on table locks acq/created with high cardinality table_id
flaneur2020 Apr 21, 2025
9f1186f
remove root label in opendal metrics
flaneur2020 Apr 21, 2025
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
remove root label in opendal metrics
  • Loading branch information
@flaneur2020
flaneur2020 committed Apr 21, 2025
commit 9f1186fe909ed0f9173f9aec2a7c123c72b5608c
1 change: 0 additions & 1 deletion src/common/storage/src/metrics_layer.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,7 +242,6 @@ impl EncodeLabelSet for OperationLabels {
fn encode(&self, mut encoder: LabelSetEncoder) -> Result<(), fmt::Error> {
(observe::LABEL_SCHEME, self.0.scheme.into_static()).encode(encoder.encode_label())?;
(observe::LABEL_NAMESPACE, self.0.namespace.as_ref()).encode(encoder.encode_label())?;
(observe::LABEL_ROOT, self.0.root.as_ref()).encode(encoder.encode_label())?;
(observe::LABEL_OPERATION, self.0.operation).encode(encoder.encode_label())?;

if let Some(error) = &self.0.error {
Expand Down
Loading