Skip to content

fix(metrics): remove high cardinality labels in metrics #17820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 21, 2025
Merged

fix(metrics): remove high cardinality labels in metrics #17820

merged 2 commits into from
Apr 21, 2025

Conversation

@flaneur2020
Copy link
Member

@flaneur2020 flaneur2020 commented Apr 21, 2025 •
edited by drmingdrmer
Loading

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

prometheus hates labels with high cardinalities.

this pr removes two high cardinality labels:

  1. table_id label in the table locks metrics, users may have thousands of tables
  2. root label in opendal access metrics, users may have thousands of stages

Tests

  • No Test - improve metrics

Type of change

  • Other (please describe): metrics enhancement

This change is Reviewable
@github-actions github-actions bot added the pr-bugfix this PR patches a bug in codebase label Apr 21, 2025
@zhang2014 zhang2014 merged commit 3547bee into main Apr 21, 2025
221 of 226 checks passed
@zhang2014 zhang2014 deleted the fix-metrics branch April 21, 2025 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-bugfix this PR patches a bug in codebase

3 participants

@flaneur2020 @zhang2014