PR to develop #32
Merged
PR to develop #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
cujomalainey requested changes Jan 13, 2022
There was a problem hiding this comment.
Overall it looks pretty good from an initial look. I just did an initial pass, I will try and take a look at it with the spec in hand tonight to verify the byte patterns. Are you familiar enough with git to squash to remove that number or do you want me to do it after submission?
cujomalainey requested changes Jan 14, 2022
| Hi Curtis, I don't know how to squash but tell me how and i will do it Charles-antoine FOURNEL Le jeu. 13 janv. 2022 à 23:51, Curtis Malainey ***@***.***> a écrit : … ***@***.**** requested changes on this pull request. Overall it looks pretty good from an initial look. I just did an initial pass, I will try and take a look at it with the spec in hand tonight to verify the byte patterns. Are you familiar enough with git to squash to remove that number or do you want me to do it after submission? ------------------------------ In src/.vscode/c_cpp_properties.json <#32 (comment)> : > @@ -0,0 +1,17 @@ +{ + "configurations": [ + { + "name": "Linux", + "includePath": [ This file should not be part of the PR as it is local to your machine ------------------------------ In examples/FecBikeTrainerDisplay/fe-c_native.ino <#32 (comment)> : > + * + * Finds a nearby Indoor bike trainer + * And display content sent by it + * + * Author Charles-Antoine FOURNEL + ************************************/ +#include <Arduino.h> +#include "ANT.h" +#include "ANTPLUS.h" +#include "bluefruit.h" +#define BAUD_RATE 115200 +#define CHANNEL_0 0 +#define TOTAL_CHANNELS 1 +#define ENCRYPTED_CHANNELS 0 + +const uint8_t NETWORK_KEY[] = {0x01, 0x02, 0x03, 0x04, 0x05, 0x06, 0x07, 0x08}; // get this from thisisant.com In one of your commits you have this number, you can squash the two commits so the history is removed or I can do it. ------------------------------ In examples/FecBikeTrainerDisplay/fe-c_native.ino <#32 (comment)> : > + * And display content sent by it + * + * Author Charles-Antoine FOURNEL + ************************************/ +#include <Arduino.h> +#include "ANT.h" +#include "ANTPLUS.h" +#include "bluefruit.h" +#define BAUD_RATE 115200 +#define CHANNEL_0 0 +#define TOTAL_CHANNELS 1 +#define ENCRYPTED_CHANNELS 0 + +const uint8_t NETWORK_KEY[] = {0x01, 0x02, 0x03, 0x04, 0x05, 0x06, 0x07, 0x08}; // get this from thisisant.com + +ArduinoNativeAntWithCallbacks ant; Unfortunately this has to be serial otherwise I can't add it as part of the CI. ------------------------------ In examples/FecBikeTrainerDisplay/fe-c_native.ino <#32 (comment)> : > + Serial.print("ANT MSG ERROR: "); + Serial.println(ant.getResponse().getErrorCode()); + } + unsigned long currentMillis = millis(); + + /** + * + * Just a quick test to switch target power + * every **interval** + * + */ + if(currentMillis - previousMillis > interval) + { + // save the last time you blinked the LED + previousMillis = currentMillis; + //Serial.println("Envoi de la puissance vise"); Is this debug code? — Reply to this email directly, view it on GitHub <#32 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABQ7FBLYO6XLN25RKDFYEV3UV5JQHANCNFSM5L4XWVUQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you authored the thread.Message ID: ***@***.***> |
| Also, From datapage 51 sheet, you can set up grade simulation from -200 to 200% i only write getter and setter and did not propose functions to set the grade with ease For example if you want to simulate a grade slope of 5 % you have to send an uint_16 of 20500 ( unit is 0.01 ) because of the -200 offset specified so its like 20500 * 0.01 = 205 - 200 = 5 which is thé targeted grade. In your antplus philosophy , should this bé implemented or its up to everyone to handle it ? Charles-antoine FOURNEL Le ven. 14 janv. 2022 à 09:08, Charles-antoine Fournel < ***@***.***> a écrit : … Hi Curtis, I don't know how to squash but tell me how and i will do it Charles-antoine FOURNEL Le jeu. 13 janv. 2022 à 23:51, Curtis Malainey ***@***.***> a écrit : > ***@***.**** requested changes on this pull request. > > Overall it looks pretty good from an initial look. I just did an initial > pass, I will try and take a look at it with the spec in hand tonight to > verify the byte patterns. Are you familiar enough with git to squash to > remove that number or do you want me to do it after submission? > ------------------------------ > > In src/.vscode/c_cpp_properties.json > <#32 (comment)> > : > > > @@ -0,0 +1,17 @@ > +{ > + "configurations": [ > + { > + "name": "Linux", > + "includePath": [ > > This file should not be part of the PR as it is local to your machine > ------------------------------ > > In examples/FecBikeTrainerDisplay/fe-c_native.ino > <#32 (comment)> > : > > > + * > + * Finds a nearby Indoor bike trainer > + * And display content sent by it > + * > + * Author Charles-Antoine FOURNEL > + ************************************/ > +#include <Arduino.h> > +#include "ANT.h" > +#include "ANTPLUS.h" > +#include "bluefruit.h" > +#define BAUD_RATE 115200 > +#define CHANNEL_0 0 > +#define TOTAL_CHANNELS 1 > +#define ENCRYPTED_CHANNELS 0 > + > +const uint8_t NETWORK_KEY[] = {0x01, 0x02, 0x03, 0x04, 0x05, 0x06, 0x07, 0x08}; // get this from thisisant.com > > In one of your commits you have this number, you can squash the two > commits so the history is removed or I can do it. > ------------------------------ > > In examples/FecBikeTrainerDisplay/fe-c_native.ino > <#32 (comment)> > : > > > + * And display content sent by it > + * > + * Author Charles-Antoine FOURNEL > + ************************************/ > +#include <Arduino.h> > +#include "ANT.h" > +#include "ANTPLUS.h" > +#include "bluefruit.h" > +#define BAUD_RATE 115200 > +#define CHANNEL_0 0 > +#define TOTAL_CHANNELS 1 > +#define ENCRYPTED_CHANNELS 0 > + > +const uint8_t NETWORK_KEY[] = {0x01, 0x02, 0x03, 0x04, 0x05, 0x06, 0x07, 0x08}; // get this from thisisant.com > + > +ArduinoNativeAntWithCallbacks ant; > > Unfortunately this has to be serial otherwise I can't add it as part of > the CI. > ------------------------------ > > In examples/FecBikeTrainerDisplay/fe-c_native.ino > <#32 (comment)> > : > > > + Serial.print("ANT MSG ERROR: "); > + Serial.println(ant.getResponse().getErrorCode()); > + } > + unsigned long currentMillis = millis(); > + > + /** > + * > + * Just a quick test to switch target power > + * every **interval** > + * > + */ > + if(currentMillis - previousMillis > interval) > + { > + // save the last time you blinked the LED > + previousMillis = currentMillis; > + //Serial.println("Envoi de la puissance vise"); > > Is this debug code? > > — > Reply to this email directly, view it on GitHub > <#32 (review)>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/ABQ7FBLYO6XLN25RKDFYEV3UV5JQHANCNFSM5L4XWVUQ> > . > Triage notifications on the go with GitHub Mobile for iOS > <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> > or Android > <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. > > You are receiving this because you authored the thread.Message ID: > ***@***.***> > |
| Hi Charles, If you don't know how to squash then i should probably do it since it is a destructive action to git history so it can be dangerous if done incorrectly and cause you to lose work. As for the philosophy I usually avoid those helpers as everyone may have a different preference for scale, but the benefit is you can write your own class in your app and extend it yourself and use it in place of the original message for both TX and RX. For TX you just use your type, for RX you just load the data pointer from the original message similar to how its done in the display from the original message then you can use the extensions. |
| Hello Charles Do you have time to address these comments or should I merge and squash them and address them later? |
| merging and going to handle rest of the cleanup in tree |
| update is squashed into original commit now as 3d695b9 so numbers have been removed from history |
src/Profiles/Fec/DataPages/ANTPLUS_FecCapabilitiesInformationDataPage.cpp Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.