Add FE-C implementation with native drive example #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This will unpack the data and build it into the API so profiles can handle the patterns easier.
This should fix up everything.
Signed-off-by: Curtis Malainey <curtis@malainey.com>
Brings in common data pages need for profiles
Signed-off-by: Curtis Malainey <curtis@malainey.com>
Signed-off-by: Curtis Malainey <curtis@malainey.com>
Signed-off-by: Curtis Malainey <curtis@malainey.com>
Signed-off-by: Curtis Malainey <curtis@malainey.com>
Signed-off-by: Curtis Malainey <curtis@malainey.com>
…information Signed-off-by: Curtis Malainey <curtis@malainey.com> Note(cujomalainey): Removed all MOxy when cherry-picking to isolate branch changes
Grabbed the wrong name when dealing with merge conflicts. Oops.
…ily tested Signed-off-by: Curtis Malainey <curtis@malainey.com>
Signed-off-by: Curtis Malainey <curtis@malainey.com>
Signed-off-by: Curtis Malainey <curtis@malainey.com>
Signed-off-by: Curtis Malainey <curtis@malainey.com>
…rmation Signed-off-by: Curtis Malainey <curtis@malainey.com> Note(cujomalainey): Removed shifting profile content to keep branches isolated till merge back
Signed-off-by: Curtis Malainey <curtis@malainey.com>
Handle cases where the rebase merged badly and conlicts were not handled correctly
Don't copy paste code, this is much better
Conflicts: .travis.yml src/BaseClasses/ANTPLUS_BaseMasterProfile.cpp src/Profiles/ANTPLUS_Profiles.h
Move datapages to the new core/base format in preparation for changing to the new get/set api, this should also futureproof the profile
Make header include more direct, minor optimization
Implemented both TX and RX
Move to new set api
profile optionally supports it
something broke in platformio
product and manufacturer info are required, so they should be requestable
So upon further reading of the profile doc it appears this profile is much more complex as it houses 4 different underlying types of power sensors each with their own transmission pattern. Therefore lets break this out for each sensor so we don't end up with spaghetti code.
Make common background data function, make common transmisison path
Power only sensors my support TE & PS page, therefore add check in datapage rotation
Implement checks for request data page
Missing required common datapage hooks
Optional datapage support can be detected by checking if a callback was installed, no need for additional bitfields
There are 4 types of power sensors, now that the internal infra is implemented (untested) we can go ahead and expose the API to change the sensor type
Now that more device types have been exposed, lets add them to the search example for proper usage demonstration
instat would be a weird thing
Move another msg over
vaid is not quite valid
Add example of how to use power sensor and build with CI
use new byte set API
move to new API
Better to define the initial data than programmatically set it ourselves
HeartRate Displays could not transmit the ModeSettings message till now as it was undefined
Show fields that can have invalid values
Fixup defines to match other profiles and remove magic numbers
Fec implementation
| Hi @cfournel can you send this as PR against the develop branch? Right now it is targeting master. Also you might want to squash your "update native" example" commit into your commit that you add your example as the history of the previous network value is still there. If you need help I can squash the commits for you. |
| continued on #32 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Add FE-C implementation ( only for indoor bike trainer , i didn't implement treadmill or rower specific datapage )