Refactor AnnotateRoutes by adding AnnotateRoutes::HeaderGenerator #790
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| I'm not a maintainer on the project, but if it helps make reviewing easier for others, it looks like this does what you described in your first point - separate logic of |
drwl approved these changes Apr 5, 2020
nard-tech deleted the feature/refactor_annotate_routes/header_generator_v1 branch vfonic pushed a commit to vfonic/annotate_models that referenced this pull request May 8, 2020
…ran#790) I noticed that `AnnotateRoutes` can be more maintainable by refactoring. I am planning to refactor `AnnotateRoutes` in this order. * separate logic of `AnnotateRoutes` into `AnnotateRoutes::HeaderGenerator`. * add methods to `AnnotateRoutes::HeaderGenerator` and refactor methods. * add `AnnotateRoutes::AnnotationProcessor` and `AnnotateRoutes::RemovalProcessor` The final goal of this refactoring is as follows. * https://github.com/nard-tech/annotate_models/blob/feature/refactor_annotate_routes/processors/lib/annotate/annotate_routes.rb * https://github.com/nard-tech/annotate_models/tree/feature/refactor_annotate_routes/processors/lib/annotate/annotate_routes So in the first I added `AnnotateRoutes::HeaderGenerator` in order to separate logic of `AnnotateRoutes` in this PR. When refactor of `AnnotateRoutes` is finished, I would like to refactor `AnnotateModels` in a like way.
This was referenced Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
I noticed that
AnnotateRoutescan be more maintainable by refactoring.I am planning to refactor
AnnotateRoutesin this order.AnnotateRoutesintoAnnotateRoutes::HeaderGenerator.AnnotateRoutes::HeaderGeneratorand refactor methods.AnnotateRoutes::AnnotationProcessorandAnnotateRoutes::RemovalProcessorThe final goal of this refactoring is as follows.
So in the first I added
AnnotateRoutes::HeaderGeneratorin order to separate logic ofAnnotateRoutesin this PR.When refactor of
AnnotateRoutesis finished, I would like to refactorAnnotateModelsin a like way.