Skip to content

Conversation

nard-tech
Copy link
Collaborator

@nard-tech nard-tech commented Feb 9, 2024

Redo version of #793 and #1008.

cf. #790, #792

In order to refactor AnnoateRoutes, I added AnnotateRoutes::AnnotationProcessor and AnnotateRoutes::RemovalProcessor.

Refactoring AnnotateRoutes is finished in this PR and I would like to refactor AnnotateModels in a like way.

@nard-tech nard-tech self-assigned this Feb 9, 2024
@nard-tech
Copy link
Collaborator Author

@ctran @drwl
Long time no see 👋.
I fixed conflict of #793 and make pull request again.
Could you please review this?

@nard-tech
Copy link
Collaborator Author

cf. git range-diff ce7f22dfba45b2e3d459edd5d24f9163f09300b2..cc5fb447bb3f2834a671b05426044d1cbb6b3806 develop..HEAD

@drwl
Copy link
Collaborator

drwl commented Feb 10, 2024

Hi @nard-tech お久しぶり, I stopped maintaining this gem and working on my own fork instead https://github.com/drwl/annotaterb, perhaps Ctran can review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants