Skip to content

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 13, 2023

Bumps snakeyaml-engine from 2.5 to 2.6.

Commits
  • cbcee5b Use explicit default for NonPrintableStyle
  • aa8933e Improve Javadoc
  • ae48bb5 Merge branch 'master' of bitbucket.org:snakeyaml/snakeyaml-engine
  • 09fa48b Improve Javadoc
  • 873cf96 Allow to change the value in MappingNode
  • fd05062 Improve Javadoc
  • 2b762dc Update README
  • ef1806e Open internal classes in StandardRepresenter
  • 25e381f Add test for protected classes
  • e7ed068 Add test for special Doubles
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
@dependabot dependabot bot added dependencies Pull requests that update a dependency file java Pull requests that update Java code labels Jan 13, 2023
@dependabot dependabot bot force-pushed the dependabot/maven/org.snakeyaml-snakeyaml-engine-2.6 branch from 6ebade1 to 091ff4c Compare January 30, 2023 07:46
@mr-c mr-c enabled auto-merge (squash) January 30, 2023 07:47
Bumps [snakeyaml-engine](https://bitbucket.org/snakeyaml/snakeyaml-engine) from 2.5 to 2.6. - [Commits](https://bitbucket.org/snakeyaml/snakeyaml-engine/branches/compare/snakeyaml-engine-2.6..snakeyaml-engine-2.5) --- updated-dependencies: - dependency-name: org.snakeyaml:snakeyaml-engine dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/maven/org.snakeyaml-snakeyaml-engine-2.6 branch from 091ff4c to 0213ce6 Compare January 30, 2023 07:48
@mr-c mr-c disabled auto-merge January 30, 2023 08:17
Copy link
Member

@kinow kinow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this version of SnakeYaml introduce schemas, replacing the previous scalar resolvers used in cwljava.

Commit that changed it: https://bitbucket.org/snakeyaml/snakeyaml-engine/commits/1e1f980416ec75c8c217dd1921b7c967fde0e726

Issue: https://bitbucket.org/snakeyaml/snakeyaml-engine/issues/38

Tests showing how to use the API: https://bitbucket.org/snakeyaml/snakeyaml-engine/src/master/src/test/java/org/snakeyaml/engine/schema/

And the Wiki page: https://bitbucket.org/snakeyaml/snakeyaml-engine/wiki/Schemas

I think we will need a schema for cwljava, replacing the existing resolvers?

@mr-c
Copy link
Member

mr-c commented Feb 1, 2023

@kinow Yep, we get to drop our hacks (140 lines) and use the provided YAML Core schema!

@mr-c mr-c force-pushed the dependabot/maven/org.snakeyaml-snakeyaml-engine-2.6 branch 3 times, most recently from 83742e3 to a0ad8ce Compare February 1, 2023 13:57
@mr-c mr-c force-pushed the dependabot/maven/org.snakeyaml-snakeyaml-engine-2.6 branch from a0ad8ce to f1eb293 Compare February 1, 2023 14:06
@coveralls
Copy link

Coverage Status

Coverage: 62.137% (-0.3%) from 62.481% when pulling f1eb293 on dependabot/maven/org.snakeyaml-snakeyaml-engine-2.6 into 03411ff on cwl-1.2.0.

Copy link
Member

@kinow kinow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@mr-c mr-c merged commit 764da6c into cwl-1.2.0 Feb 1, 2023
@mr-c mr-c deleted the dependabot/maven/org.snakeyaml-snakeyaml-engine-2.6 branch February 1, 2023 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file java Pull requests that update Java code

4 participants