Skip to content

Prefer double quotes for js #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ABaldwinHunter merged 1 commit into from
Mar 31, 2016
Merged

Prefer double quotes for js #36

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions javascript/eslintrc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ module.exports = {
"no-shadow-restricted-names": 2,
"no-undef": 2,
"no-use-before-define": 2,
"quotes": [2, "double", "avoid-escape"],
Copy link
Contributor

@gdiggs gdiggs Mar 31, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does avoid-escape do?
Copy link
Contributor

@wfleming wfleming Mar 31, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does avoid-escape do?

It looks like it allows things like 'a string containing "double quotes"', which personally I'm cool with.

@ABaldwinHunter my reading of the rule docs is that this will also allow ES6 backtick template literals (as long as they actually do some substitution). Can you confirm that's the case?
Copy link
Contributor Author

@ABaldwinHunter ABaldwinHunter Mar 31, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It means it won't diagnose a single quote as an error, if the only alternative would have been an escaped double quote.
http://eslint.org/docs/rules/quotes
Copy link
Contributor Author

@ABaldwinHunter ABaldwinHunter Mar 31, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hehe github refreshes. :p

@wfleming that was my reading as well. I think that rule only applies to es6 though, and I don't think we're using that on most of our projects.

I tried adding

var test = `test`

to a file and analyzing with double quotes rule in place, but no issue was found.
Copy link
Contributor

@wfleming wfleming Mar 31, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're using ES6 on browser: I'm trying to check that this rule will work as expected in that repo. I'm guessing/hoping "env": "es6" was not on wherever you tested that?

My expectation/hope for an ES6 repo is that

`static text`

would be a violation of this rule, but

`text with ${substitution}`

would not be.

P.S. I'm just now learning how frustrating trying to type ES6 literals into inline markdown is going to be in the future. Cool.
Copy link
Contributor Author

@ABaldwinHunter ABaldwinHunter Mar 31, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
"radix": 2,
"semi": 2,
"space-infix-ops": 2,
Expand Down