Prefer double quotes for js #36
Conversation
ABaldwinHunter force-pushed the abh-js-quotes branch from 2910f94 to 88547f0 Compare 
| "no-shadow-restricted-names": 2, | ||
| "no-undef": 2, | ||
| "no-use-before-define": 2, | ||
| "quotes": [2, "double", "avoid-escape"], |
There was a problem hiding this comment.
What does avoid-escape do?
It looks like it allows things like 'a string containing "double quotes"', which personally I'm cool with.
@ABaldwinHunter my reading of the rule docs is that this will also allow ES6 backtick template literals (as long as they actually do some substitution). Can you confirm that's the case?
There was a problem hiding this comment.
It means it won't diagnose a single quote as an error, if the only alternative would have been an escaped double quote.
http://eslint.org/docs/rules/quotes
There was a problem hiding this comment.
hehe github refreshes. :p
@wfleming that was my reading as well. I think that rule only applies to es6 though, and I don't think we're using that on most of our projects.
I tried adding
var test = `test` to a file and analyzing with double quotes rule in place, but no issue was found.
There was a problem hiding this comment.
We're using ES6 on browser: I'm trying to check that this rule will work as expected in that repo. I'm guessing/hoping "env": "es6" was not on wherever you tested that?
My expectation/hope for an ES6 repo is that
`static text` would be a violation of this rule, but
`text with ${substitution}` would not be.
P.S. I'm just now learning how frustrating trying to type ES6 literals into inline markdown is going to be in the future. Cool.
| 👍 |
| LGTM. I cannot wait for the "Code Climate found 5957891784 issues" PR on browser... |
@codeclimate/review
As per slack discussion today.