Make auto scroll work with repl buffer in non-selected frames #1521
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
rfkm force-pushed the fix-sticky-prompt branch from ae2dad3 to 8435bb5 Compare 
cider-repl.el Outdated
There was a problem hiding this comment.
Any reason not to use t instead of visible?
There was a problem hiding this comment.
As far as I understand, get-buffer-window ignores hidden frames if visible is passed.
I feel like the auto scroll feature is meaningless if the repl buffer is invisible.
There was a problem hiding this comment.
Yes, I think so.
At least, minimized ⊆ invisible is definitely true.
There was a problem hiding this comment.
Maybe we should make this a defcustom if some people would like to get auto-scrolling for invisible frames as well.
There was a problem hiding this comment.
Or just pass t?
I feel like #1508 is fine grained enough as customizability.
In any case, I'm ready to update this PR. ;-)
What shall I do?
rfkm force-pushed the fix-sticky-prompt branch from 8435bb5 to bb39da9 Compare | Done :) |
bbatsov added a commit that referenced this pull request Jan 21, 2016
Make auto scroll work with repl buffer in non-selected frames
| 👍 |
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
I noticed
cider-repl--show-maximum-outputdoesn't work with non-selected frames.(Sometimes, I move a repl buffer to sub-monitor, creating a new frame.)
This PR should make it work with non-selected frames.