[Fix #1507] Configure show-maximum-output with a defcustom #1508
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
cider-repl.el Outdated
There was a problem hiding this comment.
I get the point of the change, but I think that both the name of the defcustom and the description will be confusing for most people. In a way show-maximum-output is just an implementation detail.
| This change should be mentioned in the changelog. |
johnv02139 force-pushed the stationary-prompt branch from 88e5cf2 to 4d2f64f Compare 
| WRT variable name, we could call it |
👍 Yeah, that's a much more meaningful name. No idea who came up with a name like |
| @johnv02139 ping :-) |
| I updated and merged this myself. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Add a defcustom to control the behavior of cider-repl--show-maximum-output. The default behavior is unchanged; this commit changes nothing unless the user customizes the variable to nil, in which case, the repl buffer will not re-center itself regardless of its position.