docs: refactor react-navigation example with React Nav team feedback #1253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
mdjastrzebski requested review from AugustinLF, MattAgn and pierrezimmermannbam 
Codecov ReportBase: 94.94% // Head: 94.94% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@ ## main #1253 +/- ## ======================================= Coverage 94.94% 94.94% ======================================= Files 45 45 Lines 3088 3088 Branches 457 457 ======================================= Hits 2932 2932 Misses 156 156 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
thymikee reviewed Dec 8, 2022
thymikee reviewed Dec 8, 2022
thymikee reviewed Dec 8, 2022
thymikee approved these changes Dec 8, 2022
Member
thymikee left a comment
thymikee left a comment There was a problem hiding this comment.
Needs some small adjustments, other than that looks good!
Co-authored-by: Michał Pierzchała <thymikee@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Summary
Refactor React Navigation example based on feedback from @satya164 from React Navigation team.